You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2012/10/30 17:38:13 UTC

[jira] [Created] (WICKET-4848) Reporter of FeedbackMessage should not be set to 'null' on detach

Peter Ertl created WICKET-4848:
----------------------------------

             Summary: Reporter of FeedbackMessage should not be set to 'null' on detach
                 Key: WICKET-4848
                 URL: https://issues.apache.org/jira/browse/WICKET-4848
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 6.2.0
            Reporter: Peter Ertl
            Assignee: Peter Ertl
            Priority: Minor


When FeedbackMessages are detached via IDetachable#detach() the reporter of the message is set to null. 
This seems to be part of legacy cleanup before feedback messages were stored in the components meta data.
Since settings the reporter to null changes the state of the message and 
also partially bypasses the logic behing IApplicationSettings#setFeedbackMessageCleanupFilter(..) 
 we should remove that logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4848) Reporter of FeedbackMessage should not be set to 'null' on detach

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/WICKET-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl resolved WICKET-4848.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 6.3.0
    
> Reporter of FeedbackMessage should not be set to 'null' on detach
> -----------------------------------------------------------------
>
>                 Key: WICKET-4848
>                 URL: https://issues.apache.org/jira/browse/WICKET-4848
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.2.0
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>            Priority: Minor
>             Fix For: 6.3.0
>
>
> When FeedbackMessages are detached via IDetachable#detach() the reporter of the message is set to null. 
> This seems to be part of legacy cleanup before feedback messages were stored in the components meta data.
> Since settings the reporter to null changes the state of the message and 
> also partially bypasses the logic behing IApplicationSettings#setFeedbackMessageCleanupFilter(..) 
>  we should remove that logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira