You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by zenfenan <gi...@git.apache.org> on 2018/11/29 09:30:54 UTC
[GitHub] nifi pull request #3190: NIFI-5850: Replaced custom AWS regions enum with th...
GitHub user zenfenan opened a pull request:
https://github.com/apache/nifi/pull/3190
NIFI-5850: Replaced custom AWS regions enum with the one from AWS Jav…
…a SDK
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zenfenan/nifi NIFI-5850
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3190
----
commit 0688425f971d14e258a4955cd2d2ed7046c28466
Author: zenfenan <si...@...>
Date: 2018-11-29T09:29:23Z
NIFI-5850: Replaced custom AWS regions enum with the one from AWS Java SDK
----
---
[GitHub] nifi pull request #3190: NIFI-5850: Replaced custom AWS regions enum with th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3190
---
[GitHub] nifi issue #3190: NIFI-5850: Replaced custom AWS regions enum with the one f...
Posted by zenfenan <gi...@git.apache.org>.
Github user zenfenan commented on the issue:
https://github.com/apache/nifi/pull/3190
>
>
> @zenfenan agree that bumping the version just before a release is a good idea (and we should try to do it for multiple bundles) but I still suggest to bump the version in this PR so that we can also close #3187 and allow the community to use NiFi or the AWS NAR (built from master) with the new region.
@pvillard31 Fair point. Updated the version to the latest stable one and confirmed the new region comes up.
---
[GitHub] nifi issue #3190: NIFI-5850: Replaced custom AWS regions enum with the one f...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/3190
Thanks @zenfenan - merged to master.
---
[GitHub] nifi issue #3190: NIFI-5850: Replaced custom AWS regions enum with the one f...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/3190
@zenfenan agree that bumping the version just before a release is a good idea (and we should try to do it for multiple bundles) but I still suggest to bump the version in this PR so that we can also close #3187 and allow the community to use NiFi or the AWS NAR (built from master) with the new region.
---