You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2026/05/21 16:35:12 UTC

[PR] Fix mypy error in AWS Batch executor execute_async signature [airflow]

pierrejeambrun opened a new pull request, #67290:
URL: https://github.com/apache/airflow/pull/67290

   The AWS Batch executor fails mypy on \`main\`:
   
   \`\`\`
   providers/amazon/src/airflow/providers/amazon/aws/executors/batch/batch_executor.py:434: error:
   Argument "key" to "BatchQueuedJob" has incompatible type "TaskInstanceKey | str";
   expected "TaskInstanceKey | CallbackKey"  [arg-type]
   \`\`\`
   
   \`CallbackKey\` was changed from a \`str\` alias to a proper dataclass in #66973
   for stricter type-checking. The Batch executor's \`execute_async\` signature
   still declared \`key: TaskInstanceKey | str\`, which is no longer assignable to
   \`BatchQueuedJob.key\` (typed as \`BatchJobWorkloadKey = TaskInstanceKey | CallbackKey\`).
   
   Update the signature to use \`BatchJobWorkloadKey\`, matching the type of keys
   actually queued and passed by \`_process_workloads()\`.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.7)
   
   Generated-by: Claude Code (Opus 4.7) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix mypy error in AWS Batch executor execute_async signature [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #67290: Fix mypy error in AWS Batch executor execute_async signature
URL: https://github.com/apache/airflow/pull/67290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix mypy error in AWS Batch executor execute_async signature [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #67290: Fix mypy error in AWS Batch executor execute_async signature
URL: https://github.com/apache/airflow/pull/67290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org