You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/31 20:07:22 UTC
[GitHub] [arrow-datafusion] thinkharderdev opened a new pull request #2130: Serialize scalar UDFs in physical plan
thinkharderdev opened a new pull request #2130:
URL: https://github.com/apache/arrow-datafusion/pull/2130
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Currently in Ballista scalar UDFs are only getting serialized in the logical plan. The job would fail on execution because the scalar UDF could not be deserialized by the executor.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Add protobuf message and serde logic for Scalar UDFs in Ballista.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #2130: Serialize scalar UDFs in physical plan
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #2130:
URL: https://github.com/apache/arrow-datafusion/pull/2130#discussion_r840978674
##########
File path: ballista/rust/core/proto/datafusion.proto
##########
@@ -176,6 +176,7 @@ enum ScalarFunction {
Translate=60;
Trim=61;
Upper=62;
+ UserDefined = 63;
Review comment:
Does this cover all user-defined code or do we need to specialize for user-defined function vs user-defined aggregate functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] thinkharderdev commented on a change in pull request #2130: Serialize scalar UDFs in physical plan
Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on a change in pull request #2130:
URL: https://github.com/apache/arrow-datafusion/pull/2130#discussion_r841067798
##########
File path: ballista/rust/core/proto/datafusion.proto
##########
@@ -176,6 +176,7 @@ enum ScalarFunction {
Translate=60;
Trim=61;
Upper=62;
+ UserDefined = 63;
Review comment:
This PR in general only handles Scalar UDFs, but it's a good thing you asked because this was actually a relic of a different encoding I was trying first and was left in by accident :). Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org