You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Tilman Hausherr (Jira)" <ji...@apache.org> on 2020/01/01 11:14:00 UTC
[jira] [Comment Edited] (PDFBOX-4723) Add equals() and hashCode()
to PDAnnotation and COS objects
[ https://issues.apache.org/jira/browse/PDFBOX-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006381#comment-17006381 ]
Tilman Hausherr edited comment on PDFBOX-4723 at 1/1/20 11:13 AM:
------------------------------------------------------------------
Thanks, the alignment test is fixed indeed.
About the equals:
* I suggest to compare with getLength() first, this would prevent calling {{toTextString}} everytime
* What if one compares a "pure" COSDictionary to a COSStream and both have identical dictionary content? Wouldn't this return true when the code in COSDictionary.equals is used?
was (Author: tilman):
Thanks, the alignment text is fixed indeed.
About the equals:
* I suggest to compare with getLength() first, this would prevent calling {{toTextString}} everytime
* What if one compares a "pure" COSDictionary to a COSStream and both have identical dictionary content? Wouldn't this return true when the code in COSDictionary.equals is used?
> Add equals() and hashCode() to PDAnnotation and COS objects
> -----------------------------------------------------------
>
> Key: PDFBOX-4723
> URL: https://issues.apache.org/jira/browse/PDFBOX-4723
> Project: PDFBox
> Issue Type: Sub-task
> Components: PDModel
> Affects Versions: 2.0.18
> Reporter: Maruan Sahyoun
> Assignee: Maruan Sahyoun
> Priority: Major
> Fix For: 2.0.19, 3.0.0 PDFBox
>
>
> In order to proper support removeAll/retainAll for COSArrayList we need to detect if entries are in fact duplicates of others. This currently fails as even though one might add the same instance of an annotation object multiple times to setAnnotations getting the annotations will have individual instances. See the discussion at PDFBOX-4669.
> In order to proper support removal we need to be able to detect equality where an object is equal if the underlying COSDictionary has the same entries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org