You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by iyerr3 <gi...@git.apache.org> on 2018/08/11 19:32:10 UTC
[GitHub] madlib pull request #310: Build: Download compatible Boost if version >= 1.6...
GitHub user iyerr3 opened a pull request:
https://github.com/apache/madlib/pull/310
Build: Download compatible Boost if version >= 1.65
JIRA: MADLIB-1235
BOOST 1.65.0 removed the TR1 library which is required by MADlib till
C++11 is completely supported. Hence, we force download of a compatible
version if existing Boost is 1.65 or greater. This should be removed
when TR1 dependency is removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib bugfix/boost_incompatibility_tempfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #310
----
commit 2307c8b14f6294f7e861c7df8264c5897f923c5b
Author: Rahul Iyer <ri...@...>
Date: 2018-08-11T19:28:29Z
Build: Download compatible Boost if version >= 1.65
JIRA: MADLIB-1235
BOOST 1.65.0 removed the TR1 library which is required by MADlib till
C++11 is completely supported. Hence, we force download of a compatible
version if existing Boost is 1.65 or greater. This should be removed
when TR1 dependency is removed.
----
---
[GitHub] madlib pull request #310: Build: Download compatible Boost if version >= 1.6...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/310
---
[GitHub] madlib issue #310: Build: Download compatible Boost if version >= 1.65
Posted by kaknikhil <gi...@git.apache.org>.
Github user kaknikhil commented on the issue:
https://github.com/apache/madlib/pull/310
Tested with boost 1.67 and boost 1.55, works as expected. Apart from the log message suggestion, +1 from me.
---
[GitHub] madlib pull request #310: Build: Download compatible Boost if version >= 1.6...
Posted by kaknikhil <gi...@git.apache.org>.
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/310#discussion_r209718447
--- Diff: src/CMakeLists.txt ---
@@ -103,21 +103,29 @@ set(MAD_MODULE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/modules)
# -- Third-party dependencies: Find or download Boost --------------------------
find_package(Boost 1.47)
-
-# We use BOOST_ASSERT_MSG, which only exists in Boost 1.47 and later.
-# Unfortunately, the FindBoost module seems to be broken with respect to version
-# checking, so we will set Boost_FOUND to FALSE if the version is too old.
if(Boost_FOUND)
+ # We use BOOST_ASSERT_MSG, which only exists in Boost 1.47 and later.
+ # Unfortunately, the FindBoost module seems to be broken with respect to
+ # version checking, so we will set Boost_FOUND to FALSE if the version is
+ # too old.
if(Boost_VERSION LESS 104600)
+ message(STATUS "No sufficiently recent version (>= 1.47) of Boost was found. Will download.")
+ set(Boost_FOUND FALSE)
+ endif(Boost_VERSION LESS 104600)
+
+ # BOOST 1.65.0 removed the TR1 library which is required by MADlib till
+ # C++11 is completely supported. Hence, we force download of a compatible
+ # version if existing Boost is 1.65 or greater. FIXME: This should be
+ # removed when TR1 dependency is removed.
+ if(NOT Boost_VERSION LESS 106500)
--- End diff --
maybe add to the log message that we found a boost version > 1.65 which is incompatible.
---
[GitHub] madlib issue #310: Build: Download compatible Boost if version >= 1.65
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/310
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/645/
---