You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2008/01/04 01:39:33 UTC
[jira] Created: (COLLECTIONS-281) Change maven build to create
Collections Test Framework jar
Change maven build to create Collections Test Framework jar
-----------------------------------------------------------
Key: COLLECTIONS-281
URL: https://issues.apache.org/jira/browse/COLLECTIONS-281
Project: Commons Collections
Issue Type: Task
Affects Versions: 3.2
Reporter: Niall Pemberton
Priority: Minor
Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-281) Change maven build to create
Collections Test Framework jar
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated COLLECTIONS-281:
--------------------------------------
Fix Version/s: 3.3
> Change maven build to create Collections Test Framework jar
> -----------------------------------------------------------
>
> Key: COLLECTIONS-281
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-281
> Project: Commons Collections
> Issue Type: Task
> Affects Versions: 3.2
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 3.3
>
> Attachments: COLLECTIONS-281-build-testframework.patch
>
>
> Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COLLECTIONS-281) Change maven build to create
Collections Test Framework jar
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niall Pemberton updated COLLECTIONS-281:
----------------------------------------
Attachment: COLLECTIONS-281-build-testframework.patch
Attaching a patch which extracts the creation of the Test Framework into a separate ant build file (build-testframework.xml). Change the ant, m1 and m2 builds to all use the same ant build file to create the test framework jar.
> Change maven build to create Collections Test Framework jar
> -----------------------------------------------------------
>
> Key: COLLECTIONS-281
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-281
> Project: Commons Collections
> Issue Type: Task
> Affects Versions: 3.2
> Reporter: Niall Pemberton
> Priority: Minor
> Attachments: COLLECTIONS-281-build-testframework.patch
>
>
> Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COLLECTIONS-281) Change maven build to create
Collections Test Framework jar
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580301#action_12580301 ]
Niall Pemberton commented on COLLECTIONS-281:
---------------------------------------------
I applied all of the patch - so AFAIC its done:
http://svn.apache.org/viewvc?view=rev&revision=638061
Running the three builds (ant, m1 & m2) the source/target options used are inconsistent:
- Ant: doesn't use any source/target options when compiling, but has 1.2 in the jar's manifest for X-Compile-Source-JDK/X-Compile-Target-JDK (hard coded in src/conf/MANIFEST.MF)
- m1: uses 1.3/1.1 values for source/target options
- m2: uses 1.3/1.3 values for source/target options
IMO we should just use 1.3 for both source/target as1.2 is so old I see no reason to attempt to support it (anyone wanting 1.2 compataible versions will have to stay on an older release)
> Change maven build to create Collections Test Framework jar
> -----------------------------------------------------------
>
> Key: COLLECTIONS-281
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-281
> Project: Commons Collections
> Issue Type: Task
> Affects Versions: 3.2
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 3.3
>
> Attachments: COLLECTIONS-281-build-testframework.patch
>
>
> Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COLLECTIONS-281) Change maven build to create
Collections Test Framework jar
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580473#action_12580473 ]
Henri Yandell commented on COLLECTIONS-281:
-------------------------------------------
I'll check to see if we compile on 1.2 still, and maybe 1.1 too if I get that installed. Then we can have the info to make the decision.
> Change maven build to create Collections Test Framework jar
> -----------------------------------------------------------
>
> Key: COLLECTIONS-281
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-281
> Project: Commons Collections
> Issue Type: Task
> Affects Versions: 3.2
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 3.3
>
> Attachments: COLLECTIONS-281-build-testframework.patch
>
>
> Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COLLECTIONS-281) Change maven build to create
Collections Test Framework jar
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580248#action_12580248 ]
Henri Yandell commented on COLLECTIONS-281:
-------------------------------------------
What's the status of this one Niall? I saw you'd applied part of it.
> Change maven build to create Collections Test Framework jar
> -----------------------------------------------------------
>
> Key: COLLECTIONS-281
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-281
> Project: Commons Collections
> Issue Type: Task
> Affects Versions: 3.2
> Reporter: Niall Pemberton
> Priority: Minor
> Fix For: 3.3
>
> Attachments: COLLECTIONS-281-build-testframework.patch
>
>
> Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COLLECTIONS-281) Change maven build to create
Collections Test Framework jar
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COLLECTIONS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell closed COLLECTIONS-281.
-------------------------------------
Resolution: Fixed
Doesn't look like I'm going to do that in fact. I'm fine with doing 1.3 and have committed that in r707529.
> Change maven build to create Collections Test Framework jar
> -----------------------------------------------------------
>
> Key: COLLECTIONS-281
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-281
> Project: Commons Collections
> Issue Type: Task
> Affects Versions: 3.2
> Reporter: Niall Pemberton
> Assignee: Henri Yandell
> Priority: Minor
> Fix For: 3.3
>
> Attachments: COLLECTIONS-281-build-testframework.patch
>
>
> Currently the m2 build does not create the Collections Test Framework jar (ant and m1 builds do)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.