[GitHub] [doris] HappenLee commented on a diff in pull request #13246: [Feature](runtime-filter) add runtime filter breaking change adapt

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #13246:
URL: https://github.com/apache/doris/pull/13246#discussion_r995682550


##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -177,6 +177,9 @@ struct TQueryOptions {
   49: optional bool skip_delete_predicate = false
 
   50: optional bool enable_new_shuffle_hash_method
+
+  //

Review Comment:
   add a comment or delete the `//`



##########
be/src/vec/core/block.cpp:
##########
@@ -64,7 +64,14 @@ Block::Block(const std::vector<SlotDescriptor*>& slots, size_t block_size) {
 }
 
 Block::Block(const PBlock& pblock) {
-    CHECK(HeartbeatServer::check_be_exec_version(pblock.be_exec_version()));
+    int be_exec_version = 0;
+    if (pblock.has_be_exec_version()) {
+        be_exec_version = pblock.be_exec_version();
+    } else {
+        LOG(WARNING) << "pblock.has_be_exec_version()=false, maybe pblock not be serialized well, "

Review Comment:
   if old BE do not have the version, the log seems will print everywhere



##########
be/test/olap/bloom_filter_column_predicate_test.cpp:
##########
@@ -145,7 +143,8 @@ TEST_F(TestBloomFilterColumnPredicate, FLOAT_COLUMN_VEC) {
 
     bloom_filter->insert_fixed_len((char*)values, offsets, 3);
     ColumnPredicate* pred = BloomFilterColumnPredicateFactory::create_column_predicate(
-            0, bloom_filter, OLAP_FIELD_TYPE_FLOAT);
+            BeExecVersionManager::get_newest_version(), bloom_filter, OLAP_FIELD_TYPE_FLOAT,

Review Comment:
   the first param is column id not the version ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org