You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/28 12:10:40 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #21833: Revise distsql test cases
Pace2Car opened a new pull request, #21833:
URL: https://github.com/apache/shardingsphere/pull/21833
For #21717.
Changes proposed in this pull request:
- Revise test cases adapt to the current syntax
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21833: Revise distsql test cases
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21833:
URL: https://github.com/apache/shardingsphere/pull/21833#issuecomment-1295299609
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21833?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21833](https://codecov.io/gh/apache/shardingsphere/pull/21833?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17beae3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f21f7ab1732f589040153aff58ae519f9e3bba21?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f21f7ab) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 17beae3 differs from pull request most recent head 613a29f. Consider uploading reports for the commit 613a29f to get more accurate results
```diff
@@ Coverage Diff @@
## master #21833 +/- ##
============================================
- Coverage 60.83% 60.82% -0.01%
Complexity 2446 2446
============================================
Files 4107 4107
Lines 57342 57342
Branches 9684 9684
============================================
- Hits 34882 34879 -3
- Misses 19559 19561 +2
- Partials 2901 2902 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...source/pool/destroyer/DataSourcePoolDestroyer.java](https://codecov.io/gh/apache/shardingsphere/pull/21833/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3Bvb2wvZGVzdHJveWVyL0RhdGFTb3VyY2VQb29sRGVzdHJveWVyLmphdmE=) | `62.50% <0.00%> (-18.75%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21833: Revise distsql test cases
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21833:
URL: https://github.com/apache/shardingsphere/pull/21833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org