[jira] Commented: (MYFACES-516) Capture and restore saveState Beans and messages when using redirect navigation rule

["Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-516?page=comments#action_12357975 ] 

Mario Ivankovits commented on MYFACES-516:
------------------------------------------

We should save the requestParameterMap too.

This should be done to save parameters like in

<h:commandLink .... action="nextPage">
    <f:param name="abc" value="123" />
</h:commandLink/>

else if the navigationRule for "nextPage" uses "<redirect" this parameter will be lost.

I would like to extend my patch, but only if there is a chance to get all this stuff commited.
Its a little bit silent around this topic, so if you think we dont need it I wouldnt want to waste my time on it.

I think it would be VERY nice if we get myfaces to work with <redirect the same way as without.

Thanks!

> Capture and restore saveState Beans and messages when using redirect navigation rule
> ------------------------------------------------------------------------------------
>
>          Key: MYFACES-516
>          URL: http://issues.apache.org/jira/browse/MYFACES-516
>      Project: MyFaces
>         Type: Improvement
>   Components: Implementation
>     Versions: 1.1.1
>     Reporter: Mario Ivankovits
>     Assignee: Martin Marinschek
>  Attachments: RedirectTracker.java, impl.diff, tom.diff
>
> Ok, this is a try to get what is described in the summary.
> The heart of this patch is the RedirectTracker.
> How it works:
> *) In NavigationHandlerImpl when it comes to the redirect the RedirectTracker will capture all required (save-state beans/messages) data. The tracker appends a special parameter (_rtid=) to the redirect url so the saved state can be looked up in an map.
> *) In LifeCycleImpl in restoreView the RedirectTracker will check for the special parameter and lookup the map using its value. If an entry was found the data will be restored.
> *) In UISaveState every bean rematerialized in restoreState will put it in a request-scoped map
> Known limitations:
> *) need to make the number of tracked redirects configureable (back-button) currently its hard-coded to 20
> *) some, as I didnt tested it very well
> I added this patch as a base to discuss what could be made better, though the goal is to add this functionality to myFaces.
> I hope some else jump in and we get a vital discussion about this topic.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira