[GitHub] [trafficcontrol] moltzaum opened a new pull request #3450: TO: Cachegroup Bugfixes

[GitBox <gi...@apache.org>]

moltzaum opened a new pull request #3450: TO: Cachegroup Bugfixes
URL: https://github.com/apache/trafficcontrol/pull/3450
 
 
   ## Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
   
   **Affects Response (thus should affect documentation)**
   * Made joined fields work for cachegroup (POST and PUT)
       - parentCachegroupName
       - secondaryParentCachegroupName
       - typeName
   * Made POST include lastUpdated in the response
       (it was mentioned in the documentation beforehand)
   * Made GET coalesce localization_methods to an empty array
   * Made POST and PUT have default values for array data
   * Made PUT have default value for fallback_to_closest to mimic POST's behavior
   * Renamed the cg type to cachegroup
   
   **Fixes Response Codes**
   * Made sure 404 works for cachegroup PUT
        (wasn't broken in the the first place, but it would be good to verify)
   * Fixed bug where delete did not recognize a 404 error
   * Fixed ISE when posting twice (#3090)
   * Fixed ISE on cachegroup delete when it has servers attached (Fixes #3401)
   
   **Internal changes**
   * Removed use of NamedQuery for cachegroup Update and Create
   * Removed use of NamedExec for cachegroup Delete
   * Removed dead code from handleCoordinateUpdate
   
   **Documentation**
   * Updated documentation to the best of my ability for changes to the response mentioned above
   * The documentation was also missing a few fields
   * The cachegroup delete wasn't showing for me, so I fixed it to match other documentation for delete
      - I'm not sure why the response type for delete is `undefined`
   
   ## Which TC components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR? Please include manual steps or automated tests. 
   ### (If no tests are part of this PR, please provide explanation as to why no tests are included.)
   
   For the issues mentioned, follow the steps in the issue.
   Run the api tests for cachegroup for basic validation.
   I'd test POST, PUT, GET, and DELETE to see how the 
   
   ## Check all that apply
   
   - [ ] This PR includes tests
   - [x] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [x] This PR includes all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR does not fix a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services