[GitHub] [hadoop] vivekratnavel commented on a change in pull request #648: HDDS-1340. Add List Containers API for Recon

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #648: HDDS-1340. Add List Containers API for Recon
URL: https://github.com/apache/hadoop/pull/648#discussion_r269403451
 
 

 ##########
 File path: hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerKeyService.java
 ##########
 @@ -198,6 +198,38 @@ public void testGetKeysForContainer() throws Exception {
     assertTrue(keyMetadataList.isEmpty());
   }
 
+  @Test
+  public void testGetContainerIDList() throws Exception {
+    //Take snapshot of OM DB and copy over to Recon OM DB.
+    DBCheckpoint checkpoint = omMetadataManager.getStore()
 
 Review comment:
   Writes to OM DB is moved to setup phase in `@Before` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org