You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/01/21 16:49:14 UTC
[GitHub] [openwhisk-runtime-swift] dgrove-oss opened a new pull request
#113: build swift5.1 from released runtime-go v1.15.0
dgrove-oss opened a new pull request #113: build swift5.1 from released runtime-go v1.15.0
URL: https://github.com/apache/openwhisk-runtime-swift/pull/113
Switch to building actionloop proxy from 1.15.0 release.
Also fix duplicate publish call in .travis.yml (cut & paste bug?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-swift] dgrove-oss commented on a change in pull
request #113: build swift5.1 from released runtime-go v1.15.0
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #113: build swift5.1 from released runtime-go v1.15.0
URL: https://github.com/apache/openwhisk-runtime-swift/pull/113#discussion_r369160886
##########
File path: core/swift51Action/Dockerfile
##########
@@ -31,7 +31,7 @@ RUN curl -sL \
FROM swift:5.1.2
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=source
+ARG GO_PROXY_BUILD_FROM=release
Review comment:
I had my Apache release hat on and was figuring we should build releases from releases.
But I can see the nightly from nightly point too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-swift] rabbah commented on a change in pull
request #113: build swift5.1 from released runtime-go v1.15.0
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #113: build swift5.1 from released runtime-go v1.15.0
URL: https://github.com/apache/openwhisk-runtime-swift/pull/113#discussion_r369126496
##########
File path: core/swift51Action/Dockerfile
##########
@@ -31,7 +31,7 @@ RUN curl -sL \
FROM swift:5.1.2
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=source
+ARG GO_PROXY_BUILD_FROM=release
Review comment:
I approved this although for "latest" nightly builds we might want to keep the source mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-swift] rabbah commented on a change in pull
request #113: build swift5.1 from released runtime-go v1.15.0
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #113: build swift5.1 from released runtime-go v1.15.0
URL: https://github.com/apache/openwhisk-runtime-swift/pull/113#discussion_r369181564
##########
File path: core/swift51Action/Dockerfile
##########
@@ -31,7 +31,7 @@ RUN curl -sL \
FROM swift:5.1.2
# select the builder to use
-ARG GO_PROXY_BUILD_FROM=source
+ARG GO_PROXY_BUILD_FROM=release
Review comment:
I suppose that we can get both with docker args on the command line. So it’s a matter of picking the default here and release is fine I suppose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-swift] dgrove-oss merged pull request #113:
build swift5.1 from released runtime-go v1.15.0
Posted by GitBox <gi...@apache.org>.
dgrove-oss merged pull request #113: build swift5.1 from released runtime-go v1.15.0
URL: https://github.com/apache/openwhisk-runtime-swift/pull/113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services