[GitHub] tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig

[GitBox <gi...@apache.org>]

tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154#discussion_r170778534
 
 

 ##########
 File path: kubernetes/invoker/invoker.yml
 ##########
 @@ -93,12 +93,12 @@ spec:
                 key: api_host
 
           # Docker-related options
-          - name: "INVOKER_CONTAINER_NETWORK"
+          - name: "CONFIG_whisk_containerFactory_containerArgs_network"
             valueFrom:
               configMapKeyRef:
                 name: invoker.config
                 key: invoker_container_network
-          - name: "INVOKER_CONTAINER_DNS"
+          - name: "CONFIG_whisk_containerFactory_containerArgs_dnsServers"
             valueFrom:
               configMapKeyRef:
                 name: invoker.config
 
 Review comment:
   Sorry for the delay! 
   I can't tell whether configMapKeyRef will 'do the right thing' here; in this case 'the right thing' may not be obvious, but should be something like: 
   ```
   CONFIG_whisk_containerFactory_containerArgs_dnsServers_0=8.8.8.8
   CONFIG_whisk_containerFactory_containerArgs_dnsServers_1=8.8.4.4
   ```
   AFAIK this is the only way to produce an array typed value in lightbend config, and currently this is an array typed value. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services