You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/10/08 10:35:45 UTC
[GitHub] [james-project] chibenwa opened a new pull request #685: JAMES-3369 Email/get include inlined text in fetched properties
chibenwa opened a new pull request #685:
URL: https://github.com/apache/james-project/pull/685
This resulted in emails not being displayed in our app....
Cc @hoangdat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #685: JAMES-3369 Email/get include inlined text in fetched properties
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #685:
URL: https://github.com/apache/james-project/pull/685#discussion_r725774630
##########
File path: server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/EmailSetMethodContract.scala
##########
@@ -6,15 +6,15 @@
* to you under the Apache License, Version 2.0 (the *
* "License"); you may not use this file except in compliance *
* with the License. You may obtain a copy of the License at *
- * *
+ * *
* http://www.apache.org/licenses/LICENSE-2.0 *
- * *
+ * *
* Unless required by applicable law or agreed to in writing, *
* software distributed under the License is distributed on an *
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
* KIND, either express or implied. See the License for the *
* specific language governing permissions and limitations *
- * under the License. *
+ * under the License. *
Review comment:
formatting issues with the license?^^'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #685: JAMES-3369 Email/get include inlined text in fetched properties
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #685:
URL: https://github.com/apache/james-project/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #685: JAMES-3369 Email/get include inlined text in fetched properties
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #685:
URL: https://github.com/apache/james-project/pull/685#issuecomment-939624716
```
org.apache.james.jmap.rfc8621.memory.MemoryEmailSetMethodTest.createShouldSupportInlinedAttachmentsMixedWithRegularAttachmentsAndHtmlBody{GuiceJamesServer}
JSON documents are different:
Different keys found in node "methodResponses[1][1].list[0].bodyValues", extra: "methodResponses[1][1].list[0].bodyValues.6","methodResponses[1][1].list[0].bodyValues.7", expected: <{"4":{"isEncodingProblem":false,"isTruncated":false,"value":"<!DOCTYPE html><html><head><title></title></head><body><div>I have the most <b>brilliant</b> plan. Let me tell you all about it. What we do is, we</div></body></html>"}}> but was: <{"4":{"isEncodingProblem":false,"isTruncated":false,"value":"<!DOCTYPE html><html><head><title></title></head><body><div>I have the most <b>brilliant</b> plan. Let me tell you all about it. What we do is, we</div></body></html>"},"6":{"isEncodingProblem":false,"isTruncated":false,"value":"123456789
"},"7":{"isEncodingProblem":false,"isTruncated":false,"value":"123456789
"}}>
Array "methodResponses[1][1].list[0].htmlBody" has different length, expected: <1> but was: <3>.
Array "methodResponses[1][1].list[0].htmlBody" has different content. Extra values: [{"charset":"UTF-8","disposition":"inline","size":11,"partId":"6","blobId":"1_6","type":"text/plain","cid":"abc"}, {"charset":"UTF-8","disposition":"inline","size":11,"partId":"7","blobId":"1_7","type":"text/plain","cid":"def"}], expected: <[{"partId":"4","blobId":"1_4","size":166,"type":"text/html","charset":"UTF-8"}]> but was: <[{"charset":"UTF-8","size":166,"partId":"4","blobId":"1_4","type":"text/html"},{"charset":"UTF-8","disposition":"inline","size":11,"partId":"6","blobId":"1_6","type":"text/plain","cid":"abc"},{"charset":"UTF-8","disposition":"inline","size":11,"partId":"7","blobId":"1_7","type":"text/plain","cid":"def"}]>
```
Is this related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #685: JAMES-3369 Email/get include inlined text in fetched properties
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #685:
URL: https://github.com/apache/james-project/pull/685#issuecomment-939639525
Yes. Fixed the email/get contract but we still have some email/get calls in email/set.
Let me have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org