You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Fred Moyer <fr...@redhotpenguin.com> on 2011/03/25 17:58:26 UTC

Fwd: [rt.cpan.org #66894] Apache::SizeLimit: Linux::Smaps detection broken

---------- Forwarded message ----------
From: Christian Ruppert via RT <bu...@rt.cpan.org>
Date: Fri, Mar 25, 2011 at 9:46 AM
Subject: [rt.cpan.org #66894] Apache::SizeLimit: Linux::Smaps detection broken
To:


Fri Mar 25 12:46:38 2011: Request 66894 was acted upon.
Transaction: Ticket created by idl0r
      Queue: mod_perl
    Subject: Apache::SizeLimit: Linux::Smaps detection broken
  Broken in: 2.0.5
   Severity: Normal
      Owner: Nobody
 Requestors: idl0r@qasl.de
     Status: new
 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66894 >


Hey guys,

it looks like the Linux::Smaps detection should be improved to *not* die
if /proc/self/smaps doesn't exist. It's quite easy by just moving the
curly bracket.
Please take a look at my patch where I it has been fixed already.

Re: Fwd: [rt.cpan.org #66894] Apache::SizeLimit: Linux::Smaps detection broken

Posted by Torsten Förtsch <to...@gmx.net>.
On Friday, March 25, 2011 17:58:26 Fred Moyer wrote:
> -        if (eval { require Linux::Smaps } && Linux::Smaps->new($$)) {
> +        if (eval { require Linux::Smaps && Linux::Smaps->new($$) }) {

+1

Torsten Förtsch

-- 
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [rt.cpan.org #66894] Apache::SizeLimit: Linux::Smaps detection broken

Posted by Elizabeth Mattijsen <li...@dijkmat.nl>.
On Mar 25, 2011, at 5:58 PM, Fred Moyer wrote:
> ---------- Forwarded message ----------
> From: Christian Ruppert via RT <bu...@rt.cpan.org>
> Date: Fri, Mar 25, 2011 at 9:46 AM
> Subject: [rt.cpan.org #66894] Apache::SizeLimit: Linux::Smaps detection broken
> To:
> 
> 
> Fri Mar 25 12:46:38 2011: Request 66894 was acted upon.
> Transaction: Ticket created by idl0r
>       Queue: mod_perl
>     Subject: Apache::SizeLimit: Linux::Smaps detection broken
>   Broken in: 2.0.5
>    Severity: Normal
>       Owner: Nobody
>  Requestors: idl0r@qasl.de
>      Status: new
>  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=66894 >
> 
> 
> Hey guys,
> 
> it looks like the Linux::Smaps detection should be improved to *not* die
> if /proc/self/smaps doesn't exist. It's quite easy by just moving the
> curly bracket.
> Please take a look at my patch where I it has been fixed already.
> <0001-Fix-Linux-Smaps-detection-to-not-die-if-proc-self-sm.patch>

FWIW, I have also seen issues with some kernels.  Linux::Smaps detects support, but then the kernel only allows reading by root and not the owner of the process.  Sort of conflicts when running Apache with something other than root.  :-)



Liz


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org