[GitHub] [lucene-solr] gerlowskija edited a comment on issue #860: SOLR-13734 JWTAuthPlugin to support multiple issuers

[GitBox <gi...@apache.org>]

gerlowskija edited a comment on issue #860: SOLR-13734 JWTAuthPlugin to support multiple issuers
URL: https://github.com/apache/lucene-solr/pull/860#issuecomment-531812473
 
 
   Cross-posting this comment from JIRA.  (When JIRAs have github PR's what's the appropriate place for higher-level, non-line-specific review comments?  Is there a consensus on this?  Is one more discoverable than the other?)
   
   ----
   
   What's the purpose of the distinction between the "primary" issuer and the secondary issuers under the issuers key? I imagine the "primary" issuer is just kept around for back-compat purposes? If it's just for back-compat, I understand it needs to be done, but it's a shame. The JSON would be easier to understand (IMO) if all of the issuer-specific properties lived only under the new `issuers` key post-9.0. Would it be possible to deprecate iss, wellKnownUrl etc outside of the issuers hash in this PR? That'd make it easier to get to the cleaner alternative at some point down the road...
   
   Outside of that though, looks good to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org