You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Alexander Shraer (Created) (JIRA)" <ji...@apache.org> on 2012/03/09 02:03:58 UTC
[jira] [Created] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Consolidate membership management and add client port information
-----------------------------------------------------------------
Key: ZOOKEEPER-1411
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
Project: ZooKeeper
Issue Type: Improvement
Components: server
Reporter: Alexander Shraer
Assignee: Alexander Shraer
Fix For: 3.5.0
Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Issue Type: Sub-task (was: Improvement)
Parent: ZOOKEEPER-107
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226609#comment-13226609 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517802/ZOOKEEPER-1411-ver4.patch
against trunk revision 1297740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/985//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/985//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/985//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254427#comment-13254427 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
I opened a review board for this:
https://reviews.apache.org/r/4729/
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258904#comment-13258904 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523636/ZOOKEEPER-1411-ver11.patch
against trunk revision 1326029.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1047//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1047//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1047//console
This message is automatically generated.
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver5.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235626#comment-13235626 ]
Flavio Junqueira commented on ZOOKEEPER-1411:
---------------------------------------------
Given that the old LE code is already deprecated (ZOOKEEPER-1153), I would say that it is fine to not take it into account as Rakesh suggests. I don't feel too strongly either way. In the case we keep it, it would be a good idea to create a jira or sub-task for removing it.
I can't find a jira for removing the UDP-based implementations. If there isn't one, then we need to create one for it too.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Description:
Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
was:
Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
This also solves ZOOKEEPER-1113
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235599#comment-13235599 ]
Flavio Junqueira commented on ZOOKEEPER-1411:
---------------------------------------------
Got it, Rakesh. Thanks for the clarification. You're right, we need to remember to remove it when we get rid of UDP leader election.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238146#comment-13238146 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519911/ZOOKEEPER-1411-ver7.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1013//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1013//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1013//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Rakesh R (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235442#comment-13235442 ]
Rakesh R commented on ZOOKEEPER-1411:
-------------------------------------
Yeah, I understood setType() is throwing 'ConfigException' otherthan observer/participant and is sufficent to handle the comment#2.
But still I feel, the existing code base is not considering the 'host:port:type' pattern. If you know, please point me to that code. I am thinking to avoid unwanted conditions.
The following snippet is from existing QPC and preparing the 'host:port:port' pattern, here its not separately handling the NFE of Integer.parseInt(parts[2]). This will be just propagating to the upper layer and throwing ConfigException.
{noformat}
} else if (parts.length == 3) {
InetSocketAddress electionAddr = new InetSocketAddress(parts[0], Integer.parseInt(parts[2]));
servers.put(Long.valueOf(sid), new QuorumServer(sid, addr, electionAddr));
{noformat}
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver3.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Description:
Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
was:
Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
Summary: Consolidate membership management, distinguish between static and dynamic configuration parameters (was: Consolidate membership management and add client port information)
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Rakesh R (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235523#comment-13235523 ]
Rakesh R commented on ZOOKEEPER-1411:
-------------------------------------
@Flavio
Yeah, certainly no serious functional issues and I agree to throw exception back to the call chain. I just shared a thought, to remove the logic(also in the logs and java comments as shown below) of supporting 'host:port:type' pattern from the uploaded patch to make it fairer.
(FYI, Please see the Alex's comments regarding 'host:port:type')
{noformat}
QPC.java
private static final String wrongFormat = " does not have the form server_cofig or server_config;client_config"+
" where server_config is one of: host:port or host:port:port " +
" or host:port:port:type or host:port:type and client_config is port or host:port";
.
.
// length 3: host:port:port or host:port:type
.
.
{noformat}
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver7.patch
this should be without tabs and with an updated comment. thanks Rakesh!
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver1.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Benjamin Reed (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233242#comment-13233242 ]
Benjamin Reed commented on ZOOKEEPER-1411:
------------------------------------------
+1. since this is a rather non-trivial patch can i get another +1?
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Rakesh R (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238114#comment-13238114 ]
Rakesh R commented on ZOOKEEPER-1411:
-------------------------------------
Hi Alex, latest patch looks fine to me.
Its good to correct the log message(String wrongFormat: as it still contains the info related to 'host:port:type' and would mislead).
Also, ZK tab policy is 'Spaces only', apply the same to the patch.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259270#comment-13259270 ]
Flavio Junqueira commented on ZOOKEEPER-1411:
---------------------------------------------
+1, lgmt. thanks for all changes to the patch, alex.
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259502#comment-13259502 ]
Hudson commented on ZOOKEEPER-1411:
-----------------------------------
Integrated in ZooKeeper-trunk #1535 (See [https://builds.apache.org/job/ZooKeeper-trunk/1535/])
ZOOKEEPER-1411. Consolidate membership management, distinguish between static and dynamic configuration parameters (Revision 1328991)
Result = SUCCESS
breed : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1328991
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/util/DynamicConfigBCTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ObserverTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumBase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumUtil.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Benjamin Reed (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256989#comment-13256989 ]
Benjamin Reed commented on ZOOKEEPER-1411:
------------------------------------------
this has been reviewed and out there for a while. if there aren't any objections, i'm committing tonight.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235099#comment-13235099 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
Hi Rakesh, thanks again for the comments!
I agree with 1, 3, 4. Regarding comment 2 - this host:port:type is not something I'm adding - AFAIK it is currently permitted by QPC. The check says that if we're using FLE then electionAddr should be defined. I'm not sure whether disallowing host:port:type is something I should do here.
Maybe someone with more experience with LE can comment on this ?
Thanks,
Alex
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257367#comment-13257367 ]
Flavio Junqueira commented on ZOOKEEPER-1411:
---------------------------------------------
I have added some comments to the review board. The review is not associated to this jira, so it doesn't show up here. It looks mostly good to me, though.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235634#comment-13235634 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
ok, in this case I'll make the change Rakesh suggests and make sure that server_config is either host:port:port or host:port:port:type
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver9.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver6.patch
Rakesh's comments are addressed ZOOKEEPER-1411-ver6.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238193#comment-13238193 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519919/ZOOKEEPER-1411-ver9.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1015//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1015//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1015//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462648#comment-13462648 ]
Hudson commented on ZOOKEEPER-1411:
-----------------------------------
Integrated in ZooKeeper-trunk #1690 (See [https://builds.apache.org/job/ZooKeeper-trunk/1690/])
ZOOKEEPER-1540. ZOOKEEPER-1411 breaks backwards compatibility (Andrew Ferguson via breed) (Revision 1389711)
Result = SUCCESS
breed : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389711
Files :
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/util/DynamicConfigBCTest.java
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235461#comment-13235461 ]
Flavio Junqueira commented on ZOOKEEPER-1411:
---------------------------------------------
@Alex You're right, I hadn't looked into setType.
@Rakesh If you check the first comment of this jira, in the sample config, it sounds like Alex is proposing this new pattern: hostname:port:port:type. We currently don't use such a pattern host:port:type, at least according to the documentation and to my knowledge. I'm also not sure I understand the comment about the NFE propagating back in the call chain. Why is that an issue exactly?
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver2.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258873#comment-13258873 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
changed the methods to protected
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226423#comment-13226423 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517771/ZOOKEEPER-1411-ver2.patch
against trunk revision 1297740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/983//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/983//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/983//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Alexander Shraer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver11.patch
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Rakesh R (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239323#comment-13239323 ]
Rakesh R commented on ZOOKEEPER-1411:
-------------------------------------
+1 Looks good!
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257565#comment-13257565 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
Flavio, thanks a lot for the comments. I uploaded a new patch here and on review board.
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257642#comment-13257642 ]
Flavio Junqueira commented on ZOOKEEPER-1411:
---------------------------------------------
I just have one small comment about public methods. Would you mind fixing it, Alex? Other than that, looks good to me.
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225763#comment-13225763 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
The patch creates the option to have a config file and a separate membership file.
-----------
Example of config file:
tickTime=2000
dataDir=/home/shralex/zookeeper-3.3.2/zookeeper1
initLimit=5
syncLimit=2
membershipFile=/home/shralex/zookeeper-3.3.2/conf/zoo_replicated1.members
Example of membership file:
server.1=localhost:2780:2783:participant;localhost:2791
server.2=localhost:2781:2784;2792
server.3=localhost:2782:2785:participant;2793
-------------
the cfg file points to the membership file by specifying "membershipFile". The membership file has all information about membership and ports. You must specify all client ports in that file - this info is separated by ";" from the usual server info. The cfg file can still include client ports (or hostname and port, but if given they must be the same as in the membership file.
Backward compatibility: you can still use one configuration file and that would work fine. But, if the configuration changes (will only happen once ZK-107 is in), the config file is automatically split to two files, and the files are updated accordingly.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Rakesh R (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234141#comment-13234141 ]
Rakesh R commented on ZOOKEEPER-1411:
-------------------------------------
Hi Alex, the patch looks good to me. I have couple of suggestions/imprv points. Please go through the following:
+Comment1+
IMO, in QPC.writeMembership(), before going to upgrade the old config file, good to check the status of the membershipFilename operations. If any exception occurred during the creation/writing of the membershipFilename, make more sense to discontinue with the upgradation rather than modifying the cfg file, this would cause inconsistent config and affect ZK startup/restart.
+Comment2+
{noformat}
QuorumPeer.java
try {
electionAddr = makeAddr(serverParts[0], Integer.parseInt(serverParts[2]));
} catch (NumberFormatException e) {
setType(serverParts[2]);
}
if (serverParts.length == 3) return;
if (electionAddr == null) {
throw new ConfigException(addressStr + wrongFormat);
}
{noformat}
Say, occurred NumberFormatException and 'serverParts.length == 3' is satisfied, in this case it will continue to next level with electionAddr as null. IMO, would throw ConfigException for NumberFormatException.
Hope the combination 'host:port:type' is newly adding to the code base as part of this patch.
As I know, UDP electionAlg is not in a consistent state and also deprecated this feature. Also in the QPC, there is a check for validating the electionAddr - "Missing election port for server: ". So I feel, its not necessary to consider new combination 'host:port:type' :-)
+Comment3+
QuorumPeer.java
public String membershipFilename = null;
public String configFilename = null;
public boolean membershipBackwardCompatibility = false;
Is it OK to have private scope?
+Comment4+
Improve the code format, please adjust it a bit by removing the 'tab spaces'
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226567#comment-13226567 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517798/ZOOKEEPER-1411-ver3.patch
against trunk revision 1297740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/984//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/984//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/984//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257560#comment-13257560 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523360/ZOOKEEPER-1411-ver10.patch
against trunk revision 1326029.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1042//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1042//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1042//console
This message is automatically generated.
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232909#comment-13232909 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517810/ZOOKEEPER-1411-ver5.patch
against trunk revision 1302281.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1000//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1000//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1000//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235124#comment-13235124 ]
Flavio Junqueira commented on ZOOKEEPER-1411:
---------------------------------------------
In the way I understand the problem Rakesh is pointing out, say we have NumberFormatException (numeric string is broken) and "serverParts.length == 3". In this situation, this patch will allow the server to continue, and it shouldn't. We should throw and exception in such a run instead of allowing it to continue.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225986#comment-13225986 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517700/ZOOKEEPER-1411-ver1.patch
against trunk revision 1297740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/981//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/981//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/981//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver10.patch
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235187#comment-13235187 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
In the case you describe, when NumberFormatException is thrown, setType is called, and if the parameter is neither "participant" nor "observer", an exception is thrown by setType. If its one of these types, then the function returns and we continue normally knowing that we got host:port:type (which would be legal for the old LE algorithm)
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258905#comment-13258905 ]
Benjamin Reed commented on ZOOKEEPER-1411:
------------------------------------------
+1 looks like we are good to go?
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver8.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226684#comment-13226684 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517810/ZOOKEEPER-1411-ver5.patch
against trunk revision 1297740.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/986//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/986//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/986//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237305#comment-13237305 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519750/ZOOKEEPER-1411-ver6.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 36 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1009//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226694#comment-13226694 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
Your comments and review of this patch are very appreciated (ZOOKEEPER-1411-ver5.patch).
One thing we may consider is making QuorumServer a separate class instead of a subclass of QuorumPeer as this subclass has now grown.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1411) Consolidate membership management
and add client port information
Posted by "Alexander Shraer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1411:
----------------------------------------
Attachment: ZOOKEEPER-1411-ver4.patch
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1411) Consolidate membership
management, distinguish between static and dynamic configuration parameters
Posted by "Flavio Junqueira (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira reassigned ZOOKEEPER-1411:
-------------------------------------------
Assignee: Alexander Shraer (was: Tadeusz Andrzej Kadłubowski)
Sorry, I didn't do it right. Fixing the assignee.
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it.
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238169#comment-13238169 ]
Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519912/ZOOKEEPER-1411-ver8.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1014//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1014//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1014//console
This message is automatically generated.
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership
management and add client port information
Posted by "Alexander Shraer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235619#comment-13235619 ]
Alexander Shraer commented on ZOOKEEPER-1411:
---------------------------------------------
Thanks for the comments! So if I understand the conclusion correctly we're leaving this for now and will simplify the logic when the old LE code is removed.
Alex
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1411
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file.
> This also solves ZOOKEEPER-1113
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira