[GitHub] [airflow] jedcunningham commented on a change in pull request #20391: Fix task instance concurrency limit in a DAG affecting other DAGs

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #20391:
URL: https://github.com/apache/airflow/pull/20391#discussion_r771779335



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -581,6 +593,13 @@ def _process_executor_events(self, session: Session = None) -> int:
                 self.log.info("Setting external_id for %s to %s", ti, info)
                 continue
 
+            # update the last_scheduling_decision for all task in this dag
+            session.query(TI).filter(TI.dag_id == ti.dag_id, TI.state == State.SCHEDULED,).update(
+                {
+                    TI.last_scheduling_decision: timezone.utcnow(),

Review comment:
       ```suggestion
               # reset the last_scheduling_decision for all task in this dag
               session.query(TI).filter(TI.dag_id == ti.dag_id, TI.state == State.SCHEDULED).update(
                   {
                       TI.last_scheduling_decision: None,
   ```
   
   Don't we want to set them to null here? How does this interplay with the mini scheduler loop?

##########
File path: airflow/logs/scheduler/latest
##########
@@ -0,0 +1 @@
+./logs/scheduler/2021-12-17

Review comment:
       I assume this was accidental?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org