You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2007/12/15 19:56:43 UTC

[jira] Commented: (WICKET-1166) add sanity check on form submit for request method

    [ https://issues.apache.org/jira/browse/WICKET-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552126 ] 

Igor Vaynberg commented on WICKET-1166:
---------------------------------------

what about forms submitted via ajax?

> add sanity check on form submit for request method
> --------------------------------------------------
>
>                 Key: WICKET-1166
>                 URL: https://issues.apache.org/jira/browse/WICKET-1166
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>         Environment: Safari 3
>            Reporter: Nathan Hamblen
>            Priority: Minor
>         Attachments: submit-method.patch
>
>
> When refreshing a frameset that includes an already POST submitted Wicket form in a frame, using the redirect to render strategy, Safari erroneously requests the form's original target by GET, rather than the location that was eventually redirected to. Therefore none of the form values are available in the request object and NPEs will occur trying to access them in places like AbstractConverter.java:55.
> Because Form allows for a particular request method to be specified, I think it should also confirm that the expected method was used instead of waiting for an NPE in validation. The outcome is the same, but the cause of the error (the client) would be more evident in server logs, etc. Patch to come...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.