You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/12/26 12:47:48 UTC
[GitHub] cordova-android pull request #353: CB-11602: (android) Adds onRestart event ...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/353
CB-11602: (android) Adds onRestart event support
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Adds onRestart event support
### What testing has been done on this change?
Auto tests, tested manually in corresponding splashscreen PR
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-android CB-11602
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #353
----
commit 11e9989c4bf31280922c1b22d74e73e71b5b5852
Author: daserge <v-...@microsoft.com>
Date: 2016-12-15T09:54:07Z
CB-11602: (android) Adds onRestart event support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-android/pull/353
Closing as per [the discussion](https://lists.apache.org/thread.html/d94c0fe4bcec06ac45f1cc37978b713464faecbf7b938560cd6368e5@%3Cdev.cordova.apache.org%3E) and decision to move splashscreen plugin functionality to the platform code instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/353
This is a major API change and as such would require a version bump.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #353: CB-11602: (android) Adds onRestart event ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge closed the pull request at:
https://github.com/apache/cordova-android/pull/353
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/353
## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/353?src=pr) is 35.58% (diff: 100%)
> Merging [#353](https://codecov.io/gh/apache/cordova-android/pull/353?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage
```diff
@@ master #353 diff @@
==========================================
Files 12 12
Lines 1037 1037
Methods 205 205
Messages 0 0
Branches 173 173
==========================================
Hits 369 369
Misses 668 668
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [6c60dc5...11e9989](https://codecov.io/gh/apache/cordova-android/compare/6c60dc5dc8e487db3da599d4beef73989309d85b...11e9989c4bf31280922c1b22d74e73e71b5b5852?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #353: CB-11602: (android) Adds onRestart event support
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/353
Also, I don't have confidence in the onRestart event on Android not being fired on the first start.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org