You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/15 15:02:58 UTC
[GitHub] [apisix] kwanhur opened a new pull request #6331: ci: import shellcheck lint
kwanhur opened a new pull request #6331:
URL: https://github.com/apache/apisix/pull/6331
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
1. shellcheck lint on action
2. fix shebang missing
test case log see it [here](https://github.com/kwanhur/apisix/actions/runs/1847641492)
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #6331: ci: import shellcheck lint
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #6331:
URL: https://github.com/apache/apisix/pull/6331#issuecomment-1041005205
Hello there, plz refer to [PR #5364 comment](https://github.com/apache/apisix/pull/5364#pullrequestreview-792825733)
> By Apache's policy, only actions from GitHub or Apache can be used in the CI. So we have to use submodule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on pull request #6331: ci: import shellcheck lint
Posted by GitBox <gi...@apache.org>.
kwanhur commented on pull request #6331:
URL: https://github.com/apache/apisix/pull/6331#issuecomment-1041190362
got it :-)
I have submit another pr#6340
Kwanhur Huang
TL;DR
> 2022年2月16日 下午1:23，leslie ***@***.***> 写道：
>
>
> Hello there, Plz don't force push during the review.
>
> Commit history allows reviewers to see what has changed since the last review, which is useful for them.
>
> A forced push could ruin the review experience.
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/apisix/pull/6331#issuecomment-1041121155>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANVRBVPQ3CRKILGPYPY3FDU3MYFPANCNFSM5OOZG2OA>.
> Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
> You are receiving this because you were mentioned.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on pull request #6331: ci: import shellcheck lint
Posted by GitBox <gi...@apache.org>.
kwanhur commented on pull request #6331:
URL: https://github.com/apache/apisix/pull/6331#issuecomment-1041093656
ok, I’ll update it with submodule.
Kwanhur Huang
TL;DR
> 2022年2月16日 上午9:42，leslie ***@***.***> 写道：
>
>
> Hello there, plz refer to PR #5364 comment <https://github.com/apache/apisix/pull/5364#pullrequestreview-792825733>
> By Apache's policy, only actions from GitHub or Apache can be used in the CI. So we have to use submodule.
>
> —
> Reply to this email directly, view it on GitHub <https://github.com/apache/apisix/pull/6331#issuecomment-1041005205>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANVRBXXWQ7YJHOZ5DTLHFTU3L6J5ANCNFSM5OOZG2OA>.
> Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
> You are receiving this because you were mentioned.
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur closed pull request #6331: ci: import shellcheck lint
Posted by GitBox <gi...@apache.org>.
kwanhur closed pull request #6331:
URL: https://github.com/apache/apisix/pull/6331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6331: ci: import shellcheck lint
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6331:
URL: https://github.com/apache/apisix/pull/6331#issuecomment-1041002985
hi @kwanhur , PLAT: https://github.com/apache/apisix/actions/runs/1847690178
It looks like this action is not available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #6331: ci: import shellcheck lint
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #6331:
URL: https://github.com/apache/apisix/pull/6331#issuecomment-1041121155
Hello there, Plz don't force push during the <ins>review</ins>.
Commit history allows reviewers to see what has changed since the last review, which is <ins>useful</ins> for them.
A forced push could <ins>**ruin**</ins> the review experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org