[GitHub] [kibble] Humbedooh commented on issue #52: Refactor the configuration methods of Apache Kibble

[GitBox <gi...@apache.org>]

Humbedooh commented on issue #52:
URL: https://github.com/apache/kibble/issues/52#issuecomment-715085796


   > @skekre98 thanks for help!
   > 
   > > Do you want refactor `../setup/setup.py` to use `configparser` instead or `yaml`?
   > 
   > Yes, I think this would be more python-native solution. However, I would suggest to add this `setup/configuration.py` file where we do:
   > 
   > ```
   > class KibbleConfigParser(...):
   >     ...
   > 
   > conf = KibbleConfigParser()
   > ```
   > 
   > Then we can import the `conf` anywhere and access the configuration information. But I'm open to any suggestion.
   > 
   > One more thing: I think it would be simpler to merge dbname, host and mort of elastiscearch into single connection uri field. WDYT?
   
   Definitely +1 to merging the entire URL (I think I said the same thing earlier somewhere else), that will also make it easier to auto-configure via the command line environment, as you'll just be exporting one variable :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org