[GitHub] [tomcat] ChristopherSchultz edited a comment on issue #143: Apply deduplication to certain loaded and created Strings

[GitBox <gi...@apache.org>]

ChristopherSchultz edited a comment on issue #143: Apply deduplication to certain loaded and created Strings
URL: https://github.com/apache/tomcat/pull/143#issuecomment-470156059
 
 
   I like the idea,  but I think the implementation could be better. For instance:
   
   1. There is no need to have two collections; just use one and cache everything.
   2. The cache should be "weak" so that any value no longer used can be GC'd
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org