You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2009/07/26 15:43:31 UTC

DO NOT REPLY [Bug 47583] New: Fix occasional test failure in TestConcurrency

https://issues.apache.org/bugzilla/show_bug.cgi?id=47583

           Summary: Fix occasional test failure in TestConcurrency
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Modules: jdbc-pool
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: sebb@apache.org


Created an attachment (id=24039)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24039)
Sample test run showing failures

TestConcurrency exhibits occasional failures - about 10% in my tests - which
appear to be due to a startup timing issue.

This can be fixed by replacing:

assertEquals("Size comparison:",10, ds.getPool().getSize());
by
assertTrue("Size comparison(less than 11):",ds.getPool().getSize()<=10);

in the testSimple() method (as has been done for the other test methods in the
class).

See attached files for some sample failures.

N.B. the test output indicates either no failures or two failures.
This suggests that the failure in testSimple() may be affecting a subsequent
test, i.e. there may be a problem with the test cleanup.
Perhaps Driver.reset(); should be done after ds.close() - or even after
super.tearDown()?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 47583] Fix occasional test failure in TestConcurrency

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47583


Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Mark Thomas <ma...@apache.org>  2009-07-30 12:41:15 PST ---
Fixed in trunk. Thanks for the report.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 47583] Fix occasional test failure in TestConcurrency

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47583





--- Comment #1 from Sebb <se...@apache.org>  2009-07-26 06:55:22 PST ---
A further test shows that the tearDown() code is wrong.

I changed the assertEquals() check in testSimple() to cause a failure every
time, and this causes a failure in testBrutal().

Driver.reset() needs to be after ds.close().

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 47583] Fix occasional test failure in TestConcurrency

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47583

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Modules: jdbc-pool          |jdbc-pool
            Version|trunk                       |unspecified
            Product|Tomcat 7                    |Tomcat Modules

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org