You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/08 04:12:03 UTC

[GitHub] [iotdb] THUMarkLau commented on a change in pull request #5173: [IOTDB-2692] Fix compaction exception caused by deleted timeseries

THUMarkLau commented on a change in pull request #5173:
URL: https://github.com/apache/iotdb/pull/5173#discussion_r821305320



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionUtils.java
##########
@@ -121,20 +123,30 @@ private static void compactAlignedSeries(
       throws IOException, MetadataException {
     MultiTsFileDeviceIterator.AlignedMeasurmentIterator alignedMeasurmentIterator =
         deviceIterator.iterateAlignedSeries(device);
-    List<String> allMeasurments = alignedMeasurmentIterator.getAllMeasurements();
+    List<String> allMeasurements = alignedMeasurmentIterator.getAllMeasurements();
     List<IMeasurementSchema> measurementSchemas = new ArrayList<>();
-    for (String measurement : allMeasurments) {
+    for (String measurement : allMeasurements) {
       // TODO: use IDTable
-      measurementSchemas.add(
-          IoTDB.metaManager.getSeriesSchema(new PartialPath(device, measurement)));
+      try {
+        measurementSchemas.add(

Review comment:
       What if the series get deleted when compacting aligned series in inner space?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org