You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/08 12:33:47 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF
MaxGekk opened a new pull request #31779:
URL: https://github.com/apache/spark/pull/31779
### What changes were proposed in this pull request?
Added new tests to `UDFSuite` to check `java.time.Period`/`java.time.Duration` in UDF as input parameters as well as UDF results.
### Why are the changes needed?
To improve test coverage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running new tests:
```
$ build/sbt "test:testOnly *UDFSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31779:
URL: https://github.com/apache/spark/pull/31779#issuecomment-792755218
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135871/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31779:
URL: https://github.com/apache/spark/pull/31779#issuecomment-792820793
@cloud-fan @yaooqinn Could you review this PR, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31779:
URL: https://github.com/apache/spark/pull/31779#issuecomment-792848332
LGTM~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31779:
URL: https://github.com/apache/spark/pull/31779#issuecomment-792780949
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40454/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31779:
URL: https://github.com/apache/spark/pull/31779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31779:
URL: https://github.com/apache/spark/pull/31779#issuecomment-793466305
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org