[GitHub] [incubator-inlong] healchow commented on a change in pull request #2778: [INLONG-2654] heartbeat report to manager

[GitBox <gi...@apache.org>]

healchow commented on a change in pull request #2778:
URL: https://github.com/apache/incubator-inlong/pull/2778#discussion_r815635890



##########
File path: inlong-common/src/main/java/org/apache/inlong/common/pojo/agent/TaskSnapshotRequest.java
##########
@@ -23,31 +23,29 @@
 import java.util.Date;
 import java.util.List;
 
-/**

Review comment:
       Why remove those Javadoc?

##########
File path: inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/utils/HttpManager.java
##########
@@ -84,6 +86,13 @@ public String doSentPost(String url, Object dto) {
         return null;
     }
 
+    public static String toJsonStr(Object obj) {
+        GsonBuilder gsonBuilder = new GsonBuilder();

Review comment:
       The instance of `Gson` should be static and final, as it is a thread-safe class.

##########
File path: inlong-common/src/main/java/org/apache/inlong/common/pojo/agent/TaskSnapshotRequest.java
##########
@@ -23,31 +23,29 @@
 import java.util.Date;
 import java.util.List;
 
-/**
- * Request of the agent task snapshot
- */
 @Data
 public class TaskSnapshotRequest {
 
     /**
-     * The ip of agent

Review comment:
       Why use lower-case instead of upper-case?

##########
File path: inlong-agent/agent-core/pom.xml
##########
@@ -84,5 +84,17 @@
             <groupId>io.prometheus</groupId>
             <artifactId>simpleclient_httpserver</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.typesafe.akka</groupId>
+            <artifactId>akka-stream_2.11</artifactId>
+            <version>2.5.21</version>

Review comment:
       In the sub-module, just use the `${xxx.version}` instead of a specific version number.

##########
File path: inlong-agent/conf/agent.properties
##########
@@ -71,6 +71,7 @@ job.finish.checkInterval=6
 
 
 
+

Review comment:
       Do we need so much blank lines?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org