You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/10 23:27:02 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
nsivabalan opened a new pull request #1945:
URL: https://github.com/apache/hudi/pull/1945
- Adding some log statements
- Commenting out testsuite tests from integration tests until we investigate CI flakiness
## What is the purpose of the pull request
*This patch comments out test suite tests from integration tests. Also, adds some log statements*
## Brief change log
- Commented out test suite tests from integration tests
- Adding log statements before each command starts
## Verify this pull request
This pull request is a trivial work.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468251623
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -103,22 +103,26 @@ private static String getHiveConsoleCommandFile(String commandFile, String addit
if (additionalVar != null) {
builder.append(" --hivevar " + additionalVar + " ");
}
- return builder.append(" -f ").append(commandFile).toString();
+ builder.append(" -f ").append(commandFile);
+ System.out.println("Hive command : " + builder.toString());
Review comment:
can we clean up these s.o.p?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468265130
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -103,22 +103,26 @@ private static String getHiveConsoleCommandFile(String commandFile, String addit
if (additionalVar != null) {
builder.append(" --hivevar " + additionalVar + " ");
}
- return builder.append(" -f ").append(commandFile).toString();
+ builder.append(" -f ").append(commandFile);
+ System.out.println("Hive command : " + builder.toString());
Review comment:
this was useful in general while checking the Integ tests log output. If not for this, it wasn't easy to understand where the tests fails if tests hung or terminated half way if not for explicit exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468265130
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -103,22 +103,26 @@ private static String getHiveConsoleCommandFile(String commandFile, String addit
if (additionalVar != null) {
builder.append(" --hivevar " + additionalVar + " ");
}
- return builder.append(" -f ").append(commandFile).toString();
+ builder.append(" -f ").append(commandFile);
+ System.out.println("Hive command : " + builder.toString());
Review comment:
this was useful in general while checking the Integ tests log output. If not for this, it wasn't easy to understand where the tests fails if tests hung or terminated half way if not for explicit exception. I prefer to keep this actually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468266606
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -103,22 +103,26 @@ private static String getHiveConsoleCommandFile(String commandFile, String addit
if (additionalVar != null) {
builder.append(" --hivevar " + additionalVar + " ");
}
- return builder.append(" -f ").append(commandFile).toString();
+ builder.append(" -f ").append(commandFile);
+ System.out.println("Hive command : " + builder.toString());
Review comment:
no I meant, why not log.info() or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468266821
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -103,22 +103,26 @@ private static String getHiveConsoleCommandFile(String commandFile, String addit
if (additionalVar != null) {
builder.append(" --hivevar " + additionalVar + " ");
}
- return builder.append(" -f ").append(commandFile).toString();
+ builder.append(" -f ").append(commandFile);
+ System.out.println("Hive command : " + builder.toString());
Review comment:
We should look into why these thing are not being logged now. they showed up for sure before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468245640
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieDemo.java
##########
@@ -115,6 +116,7 @@ public void testParquetDemo() throws Exception {
}
private void setupDemo() throws Exception {
+ Thread.sleep(60 * 1000);
Review comment:
I didn't see this in the last 30 odd runs. So, gonna be tough to repro.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1945:
URL: https://github.com/apache/hudi/pull/1945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468245015
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieDemo.java
##########
@@ -115,6 +116,7 @@ public void testParquetDemo() throws Exception {
}
private void setupDemo() throws Exception {
+ Thread.sleep(60 * 1000);
Review comment:
@nsivabalan : I had earlier suggested this to unblock debugging. Can you see why data-node is coming up occasionally ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #1945: [HUDI-1175] Minor fixes for CI flakiness
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #1945:
URL: https://github.com/apache/hudi/pull/1945#discussion_r468269077
##########
File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java
##########
@@ -103,22 +103,26 @@ private static String getHiveConsoleCommandFile(String commandFile, String addit
if (additionalVar != null) {
builder.append(" --hivevar " + additionalVar + " ");
}
- return builder.append(" -f ").append(commandFile).toString();
+ builder.append(" -f ").append(commandFile);
+ System.out.println("Hive command : " + builder.toString());
Review comment:
you are right. I do see all commands are already logged. my bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org