You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/06 00:36:03 UTC

[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #84: Optimization of the output information of verification

kezhenxu94 commented on PR #84:
URL: https://github.com/apache/skywalking-infra-e2e/pull/84#issuecomment-1304679476

   > The e2e output is not working as expected in GitHub action, can we somehow revert this behaviour or fix it? @fgksgf @chunriyeqiongsaigao @kezhenxu94, take a look here as an example; the spinner is not updating in place (while it intended to be, seeing from the demo above) but repeating messages every 2 seconds, making excessive outputs. https://github.com/apache/skywalking/actions/runs/3400604239/jobs/5655409261
   
   Hi @Superskyyy . This is quite normal in terminal and I’m not surprised that the spinner doesn’t update in place. Nearly all progress bar (determined or undetermined progress bar) in GitHub Actions don’t update in place. This is due to the terminal mode, when running locally the terminal is interactive and the program can rewind back to the first character of the line and override the characters, so it looks to be “in place”, but in GitHub actions the logs are in append mode so you just don’t see the spinner updated in place. You can see this determined progress bar (with percentage) https://github.com/apache/skywalking/actions/runs/3400604239/jobs/5655409261#step:3:13 and undetermined progress bars are like `istioctl install`, `ofn install` etc. in our showcase repository (if you run showcase repo in GitHub Actions). 
   
   But I agree the output is excessive and we can add a command option like `—-batch/-B`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org