[GitHub] [lucene-solr] madrob commented on a change in pull request #1184: LUCENE-9142 Refactor IntSet operations for determinize

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #1184: LUCENE-9142 Refactor IntSet operations for determinize
URL: https://github.com/apache/lucene-solr/pull/1184#discussion_r374902793
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/util/automaton/FrozenIntSet.java
 ##########
 @@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.util.automaton;
+
+import java.util.Arrays;
+
+final class FrozenIntSet extends IntSet {
+  final int[] values;
+  final int hashCode;
+  final int state;
+
+  FrozenIntSet(int[] values, int hashCode, int state) {
+    this.values = values;
+    this.hashCode = hashCode;
+    this.state = state;
+  }
+
+  @Override
+  int[] asArray() {
 
 Review comment:
   In the case of SortedIntSet, it might make a copy, I wanted to leave it flexible for the underlying implementation on how to handles this. Renaming to getArray makes sense though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org