You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2022/06/20 13:13:24 UTC

[Bug 66131] New: Module regression

https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

            Bug ID: 66131
           Summary: Module regression
           Product: Apache httpd-2
           Version: 2.4-HEAD
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_heartmonitor
          Assignee: bugs@httpd.apache.org
          Reporter: jerome.billiras+apache@gmail.com
  Target Milestone: ---

Hi.

Bug was introduce with 2.4.54.

By setting maxworkers to 10 (svn: #1900026) and according to
HeartbeatMaxServers doc page
(https://httpd.apache.org/docs/2.4/en/mod/mod_heartmonitor.html#heartbeatmaxservers),
it's become impossible to revert to file handler for shared memory with
`HeartbeatMaxServers 0`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

--- Comment #7 from Jérôme Billiras <je...@gmail.com> ---
Doc clarification seam clear for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

--- Comment #3 from Jérôme Billiras <je...@gmail.com> ---
With only `mod_heartmonitor` enabled

`httpd -M`
> Loaded Modules:
>  core_module (static)
>  so_module (static)
>  http_module (static)
>  watchdog_module (shared)
>  authz_core_module (shared)
>  heartmonitor_module (shared)
>  mpm_event_module (shared)
>  status_module (shared)
>  unixd_module (shared)
>  version_module (shared)


I've got :
`httpd -DFOREGROUND`
> 2022-06-20 14:16:04.651920 heartmonitor:emerg - AH02284: failed to lookup provider 'shm' for 'slotmem', maybe you need to load mod_slotmem_shm?
> [Mon Jun 20 14:16:04.652112 2022] [:emerg] [pid 609:tid 140161243819328] AH00020: Configuration Failed, exiting


If a add directive `HeartbeatMaxServers 0` like it really was in <= 2.4.53
I've got :
`httpd -DFOREGROUND`
> AH00526: Syntax error on line 4 of /etc/httpd/mods-enabled/heartmonitor.load:
> HeartbeatMaxServers: Should be bigger than 10


And obviously if I enable `mod_slotmem_shm` (and comment out
`HeartbeatMaxServers 0`)
I've got :
`httpd -DFOREGROUND`
> 2022-06-20 14:21:31.070000 mpm_event:notice - AH00489: Apache/2.4.54 (Unix) configured -- resuming normal operations
> 2022-06-20 14:21:31.070155 mpm_event:info - AH00490: Server built: Jun 20 2022 14:11:05
> 2022-06-20 14:21:31.070179 core:notice - AH00094: Command line: 'httpd -D FOREGROUND'



Indeed, it better to use shared memory instead of file based, and, if I have to
use one I'll choose slotmem_shm.
But I don't use either one, it's my automatic container builder that report me
an error during config test.


As things stand, it's impossible to use file based storage. So, either we apply
this little patch which revert the possibility of using the file based storage,
or we must completely wipe out the file based storage reference in module and
doc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

--- Comment #4 from Rainer Jung <ra...@kippdata.de> ---
Committed slightly adjusted in r1902117 and suggested to backport for 2.4.x.
You might want to try it:

https://svn.apache.org/viewvc?view=revision&revision=1902117

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

Jérôme Billiras <je...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |regression
           Keywords|                            |PatchAvailable, Regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

--- Comment #5 from Jérôme Billiras <je...@gmail.com> ---
Maybe change `maxworkers <= 10` to `maxworkers < 10` like I originally do or
you can't set default value `HeartbeatMaxServers 10` without error.

Otherwise, it's ok

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

Jérôme Billiras <je...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

--- Comment #1 from Jérôme Billiras <je...@gmail.com> ---
Created attachment 38322
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=38322&action=edit
Patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

--- Comment #2 from Rainer Jung <ra...@kippdata.de> ---
I have not yet checked the code but the docs suggest, that file based will be
used if mod_slotmem_shm is not loaded. Do you load mod_slotmem_shm or not? Can
you try without? Or: if you need mod_slotmem_shm for other reasons, isn't using
it even better than file based?

Thanks and regards,

Rainer

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 66131] Module regression

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66131

--- Comment #6 from Rainer Jung <ra...@kippdata.de> ---
Thank you! Condition fixed in r1902130, docs added in r1902132, typo fix in
1902133. I would be grateful, if you could check the docs clarification whether
I git the conditions for flat-file right.

https://svn.apache.org/viewvc?view=revision&revision=r1902130

https://svn.apache.org/viewvc?view=revision&revision=r1902132
https://svn.apache.org/viewvc?view=revision&revision=r1902133

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org