You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/21 03:24:33 UTC
[GitHub] [pulsar] murong00 opened a new pull request #10992: [Issue 10990] Fix the default value of httpServerPort in reference conf
murong00 opened a new pull request #10992:
URL: https://github.com/apache/pulsar/pull/10992
### Motivation
Fixes #10990
### Modifications
Change the default value of `httpServerPort` to `8080`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10992: [Issue 10990] Fix the default value of httpServerPort in reference conf
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10992:
URL: https://github.com/apache/pulsar/pull/10992#discussion_r655052037
##########
File path: site2/docs/reference-configuration.md
##########
@@ -83,7 +83,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|zkRetryBackoffMaxMs|The maximum time that the Zookeeper client backoff retries in milliseconds.|10000|
|zkEnableSecurity|Set ACLs on every node written on ZooKeeper, allowing users to read and write BookKeeper metadata stored on ZooKeeper. In order to make ACLs work you need to setup ZooKeeper JAAS authentication. All the bookies and Client need to share the same user, and this is usually done using Kerberos authentication. See ZooKeeper documentation.|false|
|httpServerEnabled|The flag enables/disables starting the admin http server.|false|
-|httpServerPort|The http server port to listen on. By default, the value is 8080. Use `8000` as the port to keep it consistent with prometheus stats provider.|8000
+|httpServerPort|The http server port to listen on. By default, the value is 8080. Use `8000` as the port to keep it consistent with prometheus stats provider.|8080
Review comment:
```suggestion
|httpServerPort|The HTTP server port to listen on. By default, the value is `8080`. If you want to keep it consistent with the Prometheus stats provider, you can set it to `8000`.|8080
```
Do you mean this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10992: [Issue 10990] Fix the default value of httpServerPort in reference conf
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10992:
URL: https://github.com/apache/pulsar/pull/10992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10992: [Issue 10990] Fix the default value of httpServerPort in reference conf
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10992:
URL: https://github.com/apache/pulsar/pull/10992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] murong00 commented on a change in pull request #10992: [Issue 10990] Fix the default value of httpServerPort in reference conf
Posted by GitBox <gi...@apache.org>.
murong00 commented on a change in pull request #10992:
URL: https://github.com/apache/pulsar/pull/10992#discussion_r655088496
##########
File path: site2/docs/reference-configuration.md
##########
@@ -83,7 +83,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|zkRetryBackoffMaxMs|The maximum time that the Zookeeper client backoff retries in milliseconds.|10000|
|zkEnableSecurity|Set ACLs on every node written on ZooKeeper, allowing users to read and write BookKeeper metadata stored on ZooKeeper. In order to make ACLs work you need to setup ZooKeeper JAAS authentication. All the bookies and Client need to share the same user, and this is usually done using Kerberos authentication. See ZooKeeper documentation.|false|
|httpServerEnabled|The flag enables/disables starting the admin http server.|false|
-|httpServerPort|The http server port to listen on. By default, the value is 8080. Use `8000` as the port to keep it consistent with prometheus stats provider.|8000
+|httpServerPort|The http server port to listen on. By default, the value is 8080. Use `8000` as the port to keep it consistent with prometheus stats provider.|8080
Review comment:
Yes, I have addressed your comment, please take a look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org