You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/22 04:21:44 UTC

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

wilfred-s commented on a change in pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r811566198



##########
File path: pkg/cache/nodes.go
##########
@@ -212,6 +213,15 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode *v1.Node) {
 		return
 	}
 
+	if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
+		schedulerNode.ready = common.HasReadyCondition(newNode)

Review comment:
       The `nodesMap` looks broken. I think we have a bigger issue in this code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org