You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2020/01/21 23:54:41 UTC

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15089


Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................

IMPALA-6772: Bump ORC version to 1.6.2-p6

Bump our ORC version to include fixes for ORC-414, ORC-580, ORC-581,
ORC-586, ORC-589, ORC-590, and ORC-591. The new ORC version also
unblocks IMPALA-9226 which requires EncodedStringVectorBatch introduced
in ORC-1.6.

Tests:
 - Run scanners test for orc/def/block.

Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/15089/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 00:10:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5450/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 00:56:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5450/


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 01:07:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................

IMPALA-6772: Bump ORC version to 1.6.2-p6

Bump our ORC version to include fixes for ORC-414, ORC-580, ORC-581,
ORC-586, ORC-589, ORC-590, and ORC-591. The new ORC version also
unblocks IMPALA-9226 which requires EncodedStringVectorBatch introduced
in ORC-1.6.

Due to other changes in native-toolchain, this patch also bumps versions
of LLVM and crcutil.

Tests:
 - Run scanners test for orc/def/block.

Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Reviewed-on: http://gerrit.cloudera.org:8080/15089
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5488/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 00:00:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15089

to look at the new patch set (#2).

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................

IMPALA-6772: Bump ORC version to 1.6.2-p6

Bump our ORC version to include fixes for ORC-414, ORC-580, ORC-581,
ORC-586, ORC-589, ORC-590, and ORC-591. The new ORC version also
unblocks IMPALA-9226 which requires EncodedStringVectorBatch introduced
in ORC-1.6.

Due to other changes in native-toolchain, this patch also bumps versions
of LLVM and crcutil.

Tests:
 - Run scanners test for orc/def/block.

Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
---
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
2 files changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/15089/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 04:57:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 09:56:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5491/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 02:14:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6772: Bump ORC version to 1.6.2-p6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15089 )

Change subject: IMPALA-6772: Bump ORC version to 1.6.2-p6
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5453/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eec92238b12179502d6a9001ee2ba24bfa96b77
Gerrit-Change-Number: 15089
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2020 05:06:06 +0000
Gerrit-HasComments: No