You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/16 15:49:33 UTC

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

bzp2010 commented on code in PR #7046:
URL: https://github.com/apache/apisix/pull/7046#discussion_r873888895


##########
.github/workflows/centos7-ci.yml:
##########
@@ -79,6 +79,8 @@ jobs:
 
     - name: Run other docker containers for test
       run: |
+        # generating SSL certificates for Kafka
+        keytool -genkeypair -keyalg RSA -dname "CN=127.0.0.1" -alias 127.0.0.1 -keystore ./ci/pod/kafka/kafka-server/selfsigned.jks -validity 365 -keysize 2048 -storepass changeit

Review Comment:
   ![image](https://user-images.githubusercontent.com/8078418/168632771-e449b3f5-5630-4be0-8275-a469b62a719d.png)
   **First make sure that the certificate exists for docker-compose to start kafka.**



##########
ci/linux_openresty_common_runner.sh:
##########
@@ -21,6 +21,9 @@
 before_install() {
     sudo cpanm --notest Test::Nginx >build.log 2>&1 || (cat build.log && exit 1)
 
+    # generating SSL certificates for Kafka
+    keytool -genkeypair -keyalg RSA -dname "CN=127.0.0.1" -alias 127.0.0.1 -keystore ./ci/pod/kafka/kafka-server/selfsigned.jks -validity 365 -keysize 2048 -storepass changeit
+

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org