You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by MaurGi <gi...@git.apache.org> on 2018/06/12 22:22:09 UTC
[GitHub] storm pull request #2712: Update Multilang-protocol.md
GitHub user MaurGi opened a pull request:
https://github.com/apache/storm/pull/2712
Update Multilang-protocol.md
Adding list of supported languages and a link to the c# adapter we have published recently -
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MaurGi/storm patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2712.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2712
----
commit ce7630229f352d3c283a066a026cec3a2cbe1343
Author: Mauro Giusti <ma...@...>
Date: 2018-06-12T22:21:55Z
Update Multilang-protocol.md
Adding list of supported languages and a link to the c# adapter we have published recently -
----
---
[GitHub] storm pull request #2712: Update Multilang-protocol.md
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2712#discussion_r195078534
--- Diff: docs/Multilang-protocol.md ---
@@ -7,6 +7,18 @@ This page explains the multilang protocol as of Storm 0.7.1. Versions prior to 0
# Storm Multi-Language Protocol
+## Supported Lanugages
+
+Storm Multi-Language has implementation in the following languages:
+
+- [JavaScript](../storm-multilang/javascript)
--- End diff --
The docs will be compiled as html and placed to website, so docs should not refer outside of docs directory. You can describe maven artifacts instead, like
* Javascript: org.apache.storm / multilang-javascript
* Python: org.apache.storm / multilang-python
* Ruby: org.apache.storm / multilang-ruby
---
[GitHub] storm issue #2712: Update Multilang-protocol.md
Posted by MaurGi <gi...@git.apache.org>.
Github user MaurGi commented on the issue:
https://github.com/apache/storm/pull/2712
@HeartSaVioR how do I squash an existing PR in GitHub? I don't see any option on the UI, do I make a new branch? thanks -
---
[GitHub] storm issue #2712: Update Multilang-protocol.md
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2712
@MaurGi OK never mind. I'll handle it during merging. Thanks for the contribution!
---
[GitHub] storm pull request #2712: Update Multilang-protocol.md
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2712
---
[GitHub] storm pull request #2712: Update Multilang-protocol.md
Posted by MaurGi <gi...@git.apache.org>.
Github user MaurGi commented on a diff in the pull request:
https://github.com/apache/storm/pull/2712#discussion_r195140675
--- Diff: docs/Multilang-protocol.md ---
@@ -7,6 +7,18 @@ This page explains the multilang protocol as of Storm 0.7.1. Versions prior to 0
# Storm Multi-Language Protocol
+## Supported Lanugages
+
+Storm Multi-Language has implementation in the following languages:
+
+- [JavaScript](../storm-multilang/javascript)
--- End diff --
got it - fixed, thanks
---
[GitHub] storm issue #2712: Update Multilang-protocol.md
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2712
Looks good.
---
[GitHub] storm issue #2712: Update Multilang-protocol.md
Posted by MaurGi <gi...@git.apache.org>.
Github user MaurGi commented on the issue:
https://github.com/apache/storm/pull/2712
thanks for the feedback, modified and resubmitted -
---