You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Sergey Shelukhin (JIRA)" <ji...@apache.org> on 2018/02/12 22:12:00 UTC
[jira] [Comment Edited] (HIVE-18629) copyValues in
BytesColumnVector may be missing null checks
[ https://issues.apache.org/jira/browse/HIVE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361527#comment-16361527 ]
Sergey Shelukhin edited comment on HIVE-18629 at 2/12/18 10:11 PM:
-------------------------------------------------------------------
[~mmccline] this patch as is will either already set noNulls to false when isNull is set to true, or throw an error.
I think throwing an error is a better approach if the input vector is corrupted than silently fixing it up, potentially in incorrect direction
was (Author: sershe):
[~mmccline] this patch as is will either already set noNulls to false when isNull is set to true, or throw an error
> copyValues in BytesColumnVector may be missing null checks
> ----------------------------------------------------------
>
> Key: HIVE-18629
> URL: https://issues.apache.org/jira/browse/HIVE-18629
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Major
> Attachments: HIVE-18629.01.patch, HIVE-18629.02.patch, HIVE-18629.03.patch, HIVE-18629.patch
>
>
> {noformat}
> Caused by: java.lang.NullPointerException
> at java.lang.System.arraycopy(Native Method)
> at org.apache.hadoop.hive.ql.exec.vector.BytesColumnVector.setVal(BytesColumnVector.java:173)
> at org.apache.hadoop.hive.ql.exec.vector.BytesColumnVector.copySelected(BytesColumnVector.java:333)
> at org.apache.hadoop.hive.ql.exec.vector.expressions..evaluate(IfExprStringGroupColumnStringGroupColumn.java:83)
> at org.apache.hadoop.hive.ql.exec.vector.VectorSelectOperator.process(VectorSelectOperator.java:133)
> {noformat}
> IfExprStringGroupColumnStringGroupColumn code below the v1.isRepeating case has isNull checks for v2/v3 buffers that copySelected is missing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)