[GitHub] michellethomas commented on issue #6358: Fixing sort issue with area chart and adding tests

[GitBox <gi...@apache.org>]

michellethomas commented on issue #6358: Fixing sort issue with area chart and adding tests
URL: https://github.com/apache/incubator-superset/pull/6358#issuecomment-457419302
 
 
   This PR is a bit old but still relevant, so I rebased and will merge it in. I don't think the line `chart_data = sorted(chart_data, key=lambda x: tuple(x['key']))` is necessary anymore for determining the color for time shift lines because we have code that assigns a color based on the label, but I'm leaving it in because it keeps the legend sorted. The `self.sort_series` happens before this line so we don't want to be resorting in that case. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org