You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@juneau.apache.org by GitBox <gi...@apache.org> on 2022/11/08 16:02:59 UTC
[GitHub] [juneau] garydgregory opened a new pull request, #67: Update some dependencies
garydgregory opened a new pull request, #67:
URL: https://github.com/apache/juneau/pull/67
- Jetty 9 to 11
- Hibernate 5.6.12.Final to 5.6.14.Final
- Spring Boot 2.7.4 to 2.7.5
- Add a default Maven goal
- Use GitHub Dependabot once a week
- Use GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies and build on GitHub
Posted by Gary Gregory <ga...@gmail.com>.
Thank you James! Green builds on https://github.com/apache/juneau/actions
Gary
On Wed, Nov 23, 2022, 12:45 James Bognar <ja...@apache.org> wrote:
> @ garydgregory - I believe I've fixed the CI maven build failure
> (cross-fingers). I converted the exhaustive tests that go against a
> live servlet with a unit test, so no pipes to break.
>
> ---------- Forwarded message ---------
> From: GitBox <gi...@apache.org>
> Date: Tue, Nov 15, 2022 at 5:38 PM
> Subject: [GitHub] [juneau] garydgregory commented on pull request #67:
> Update some dependencies and build on GitHub
> To: <de...@juneau.apache.org>
>
>
>
> garydgregory commented on PR #67:
> URL: https://github.com/apache/juneau/pull/67#issuecomment-1315961212
>
> @jamesbognar
> I've seen broken pipe errors in a completely different context in
> the past: Between a JDBC driver and a database when after a long
> period of inactivity, the database side closes the connection, and
> when the client tries to use the connection, it fails with a broken
> pipe error message.
> Could something similar be happening here? A server closes a socket
> when the client does not expect it? It seems unlikely but there is
> something about this environment that is working for the build :-(
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
Fwd: [GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies and build on GitHub
Posted by James Bognar <ja...@apache.org>.
@ garydgregory - I believe I've fixed the CI maven build failure
(cross-fingers). I converted the exhaustive tests that go against a
live servlet with a unit test, so no pipes to break.
---------- Forwarded message ---------
From: GitBox <gi...@apache.org>
Date: Tue, Nov 15, 2022 at 5:38 PM
Subject: [GitHub] [juneau] garydgregory commented on pull request #67:
Update some dependencies and build on GitHub
To: <de...@juneau.apache.org>
garydgregory commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1315961212
@jamesbognar
I've seen broken pipe errors in a completely different context in
the past: Between a JDBC driver and a database when after a long
period of inactivity, the database side closes the connection, and
when the client tries to use the connection, it fails with a broken
pipe error message.
Could something similar be happening here? A server closes a socket
when the client does not expect it? It seems unlikely but there is
something about this environment that is working for the build :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1314431605
Hi @jamesbognar Would you be able to check this branch soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1325463197
Green build!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1307695618
Hi @jamesbognar,
Any thoughts on the broken pipe failures? Do you see this failure in a local build of this branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1307577838
> That should be writing to the working directory (./jetty-thread-dump-0.log), not the root directory. Not sure why it's ending up in root.
I fixed that in this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] jamesbognar commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
jamesbognar commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1315948502
I don't know why the maven build fails in GitHub. I tested it locally and these changes were fine. I merged your changes and the Jenkins build results were fine indicating that there isn't a regression:
https://ci-builds.apache.org/blue/organizations/jenkins/Juneau%2FJuneau-Java-11/detail/Juneau-Java-11/755/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1315961212
@jamesbognar
I've seen broken pipe errors in a completely different context in the past: Between a JDBC driver and a database when after a long period of inactivity, the database side closes the connection, and when the client tries to use the connection, it fails with a broken pipe error message.
Could something similar be happening here? A server closes a socket when the client does not expect it? It seems unlikely but there is something about this environment that is working for the build :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] garydgregory commented on pull request #67: Update some dependencies
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1307462040
For me, the build passes locally on Windows, these are odd permission failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] github-code-scanning[bot] commented on a diff in pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #67:
URL: https://github.com/apache/juneau/pull/67#discussion_r1016876731
##########
juneau-microservice/juneau-microservice-ftest/src/test/java/org/apache/juneau/rest/test/TestMicroservice.java:
##########
@@ -159,7 +159,7 @@
private static int dumpCount = 0;
public static void jettyDump(RequestLine rl, StatusLine sl) {
- try (FileWriter fw = new FileWriter(microservice.getConfig().get("Logging/logDir").orElse("") + "/jetty-thread-dump-"+(dumpCount++)+".log")) {
+ try (FileWriter fw = new FileWriter(microservice.getConfig().get("Logging/logDir").orElse(".") + "/jetty-thread-dump-"+(dumpCount++)+".log")) {
Review Comment:
## Uncontrolled data used in path expression
This path depends on a [user-provided value](1).
This path depends on a [user-provided value](2).
This path depends on a [user-provided value](3).
This path depends on a [user-provided value](4).
This path depends on a [user-provided value](5).
[Show more details](https://github.com/apache/juneau/security/code-scanning/46)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] jamesbognar commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
jamesbognar commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1307757284
@garydgregory - I'll have to check out your branch and try it myself. I won't be able to get to it today though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] jamesbognar commented on pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
jamesbognar commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1317128184
In this case the broken pipe is in the HTTP layer. These tests should be running at most around 10 seconds. It's really just HttpClient encountering a broken pipe trying to read from the servlet. Something wonky is going on with the network layer in the build environment. I'm curious to know if it's repeatable. Only 22 of the 1000 tests actually failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] jamesbognar commented on pull request #67: Update some dependencies
Posted by GitBox <gi...@apache.org>.
jamesbognar commented on PR #67:
URL: https://github.com/apache/juneau/pull/67#issuecomment-1307489563
That should be writing to the working directory (./jetty-thread-dump-0.log), not the root directory. Not sure why it's ending up in root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [juneau] jamesbognar merged pull request #67: Update some dependencies and build on GitHub
Posted by GitBox <gi...@apache.org>.
jamesbognar merged PR #67:
URL: https://github.com/apache/juneau/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@juneau.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org