You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/22 00:07:34 UTC

[GitHub] [calcite] jamesstarr opened a new pull request #2655: [CALCITE-4942] Remove metadata boilerplate

jamesstarr opened a new pull request #2655:
URL: https://github.com/apache/calcite/pull/2655


   MetadataHandler's method getDef() and the generic referencing a Metadata
   subtype provide no value in current implementation of Metadata.  Removing
   them reduces the amount of code to define a Metadata type as well as
   clearify the api.  This will require downstream projects that have custom
   metadata type to remove the generic from their Handler class.
   
   * Deprecating MetadataDef, BuiltInMetadata.{extends Metadata},
     BuiltInMetadata.{extends Metadata}.Handler, internal methods of
     ChainedRelMetadataProvider, BuiltInMethod referencing Metadata
     methods.
   * Reworking BuiltInMetadata to have the Handlers at the top level.
     Extending the new Handlers with the old hanlders to reduces breaking
     downstream projects.
   * Adding default implementation to MetadataHandler#getDef
   * Removing generic from RelMetadataHandler
   * Reworking creation validation in ReflectiveRelMetadataProvider


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] vlsi commented on pull request #2655: [CALCITE-4942] Remove metadata boilerplate

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #2655:
URL: https://github.com/apache/calcite/pull/2655#issuecomment-999565662


   I was not involved in Metadata development a lot, nor did I use it a lot, however, I think `MetadataDef` was not that useful, so +1 for removing the code and making the code easier to follow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org