You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/12/20 17:27:14 UTC

[jira] [Commented] (QPID-4517) Java Broker: default log4j configuration outputs line numbers, which is a performance drag

    [ https://issues.apache.org/jira/browse/QPID-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537130#comment-13537130 ] 

Robbie Gemmell commented on QPID-4517:
--------------------------------------

Seems reasonable enough. I guess the question is whether its harder to analyse the messages without the file and line numbers and if so whether any performance increase offsets that.

As you say, its unlikely to offer anywhere near that improvement in a real world use, but it would be interesting to know how much. I imagine persistence would near completely nullify it, and I guess the worst case scenario of connection/session-per-message type usage generating lots of logging is another interesting one, but on the flip side that will also have the effect of making network I/O dominate performance during connection/session creation.
                
> Java Broker: default log4j configuration outputs line numbers, which is a performance drag
> ------------------------------------------------------------------------------------------
>
>                 Key: QPID-4517
>                 URL: https://issues.apache.org/jira/browse/QPID-4517
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: 0.20
>            Reporter: Philip Harvey
>            Assignee: Robbie Gemmell
>            Priority: Minor
>         Attachments: 0001-QPID-4517-modify-broker-log4j-configuration-to-use-l.patch
>
>
> By default we produce this sort of logging:
> {noformat}
> 2012-12-20 09:52:51,490 INFO  [main] (AbstractConfiguration.java:124) - Tag:'path'
> {noformat}
> Including line numbers is slow, as described by the log4j documentation (http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html):
> "WARNING Generating caller location information is extremely slow and should be avoided unless execution speed is not an issue."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org