You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2023/12/06 18:39:33 UTC
[PR] [MINOR] Fixing streamer props in integ tests [hudi]
nsivabalan opened a new pull request, #10260:
URL: https://github.com/apache/hudi/pull/10260
### Change Logs
Fixing streamer props in integ tests. I have filed a follow up https://issues.apache.org/jira/browse/HUDI-7187 to fix all properties. but for now, aligning all properties to be same.
### Impact
low.
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #10260:
URL: https://github.com/apache/hudi/pull/10260#discussion_r1417903557
##########
docker/demo/config/test-suite/test-metadata-aggressive-clean-archival-inline-compact.properties:
##########
@@ -27,17 +27,17 @@ hoodie.keep.min.commits=12
hoodie.keep.max.commits=14
hoodie.metadata.enable=true
hoodie.compact.inline=true
-hoodie.streamer.source.test.num_partitions=100
-hoodie.streamer.source.test.datagen.use_rocksdb_for_storing_existing_keys=false
-hoodie.streamer.source.test.max_unique_records=100000000
-hoodie.streamer.source.input.selector=org.apache.hudi.integ.testsuite.helpers.DFSTestSuitePathSelector
+hoodie.deltastreamer.source.test.num_partitions=100
Review Comment:
nope. it was causing some issues w/ integ tests specifically. I will follow up w/ a patch where we change all configs to new config keys.
for a end user this should not be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #10260:
URL: https://github.com/apache/hudi/pull/10260#discussion_r1418063296
##########
docker/demo/config/test-suite/test-metadata-aggressive-clean-archival-inline-compact.properties:
##########
@@ -27,17 +27,17 @@ hoodie.keep.min.commits=12
hoodie.keep.max.commits=14
hoodie.metadata.enable=true
hoodie.compact.inline=true
-hoodie.streamer.source.test.num_partitions=100
-hoodie.streamer.source.test.datagen.use_rocksdb_for_storing_existing_keys=false
-hoodie.streamer.source.test.max_unique_records=100000000
-hoodie.streamer.source.input.selector=org.apache.hudi.integ.testsuite.helpers.DFSTestSuitePathSelector
+hoodie.deltastreamer.source.test.num_partitions=100
Review Comment:
@xushiyan these are test-specific configs which are not migrated to `hoodie.streamer` prefix. I don't know why the related tests did not fail before. We can investigate it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #10260:
URL: https://github.com/apache/hudi/pull/10260#issuecomment-1843943418
failure was due to unrelated failure. going ahead w/ landing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #10260:
URL: https://github.com/apache/hudi/pull/10260#discussion_r1417892303
##########
docker/demo/config/test-suite/test-metadata-aggressive-clean-archival-inline-compact.properties:
##########
@@ -27,17 +27,17 @@ hoodie.keep.min.commits=12
hoodie.keep.max.commits=14
hoodie.metadata.enable=true
hoodie.compact.inline=true
-hoodie.streamer.source.test.num_partitions=100
-hoodie.streamer.source.test.datagen.use_rocksdb_for_storing_existing_keys=false
-hoodie.streamer.source.test.max_unique_records=100000000
-hoodie.streamer.source.input.selector=org.apache.hudi.integ.testsuite.helpers.DFSTestSuitePathSelector
+hoodie.deltastreamer.source.test.num_partitions=100
Review Comment:
can you clarify this change pls: is this broken due to the `streamer` config key? and you planned to change it back to `hoodie.streamer.*` later so this is temp change to make test pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10260:
URL: https://github.com/apache/hudi/pull/10260#issuecomment-1843551716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f9a1193aa9438fa9e5f1a1fbe569b398037cf54b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21343",
"triggerID" : "f9a1193aa9438fa9e5f1a1fbe569b398037cf54b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f9a1193aa9438fa9e5f1a1fbe569b398037cf54b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21343)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10260:
URL: https://github.com/apache/hudi/pull/10260#issuecomment-1843697333
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f9a1193aa9438fa9e5f1a1fbe569b398037cf54b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21343",
"triggerID" : "f9a1193aa9438fa9e5f1a1fbe569b398037cf54b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f9a1193aa9438fa9e5f1a1fbe569b398037cf54b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21343)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #10260:
URL: https://github.com/apache/hudi/pull/10260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Fixing streamer props in integ tests [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10260:
URL: https://github.com/apache/hudi/pull/10260#issuecomment-1843541515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f9a1193aa9438fa9e5f1a1fbe569b398037cf54b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f9a1193aa9438fa9e5f1a1fbe569b398037cf54b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f9a1193aa9438fa9e5f1a1fbe569b398037cf54b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org