You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/02/10 08:23:00 UTC
[kyuubi] branch branch-1.6 updated: [KYUUBI #4302] Change log level from debug to info for creating work dir
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.6
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.6 by this push:
new 5f7ef555f [KYUUBI #4302] Change log level from debug to info for creating work dir
5f7ef555f is described below
commit 5f7ef555f3ebacab360b9fda242d4abfd2852e5f
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Fri Feb 10 16:22:19 2023 +0800
[KYUUBI #4302] Change log level from debug to info for creating work dir
### _Why are the changes needed?_
The message is not noisy and is helpful when failing to create, e.g. no permission.
```
2023-02-10 14:30:32.731 INFO org.apache.kyuubi.operation.LaunchEngine: Processing simba's query[d51a4def-d3d7-454b-a63d-28e27a1e3c3f]: RUNNING_STATE -> ERROR_STATE, time taken: 0.1 seconds
Error: org.apache.kyuubi.KyuubiSQLException: Error operating LaunchEngine: java.io.IOException: 权限不够
at java.io.UnixFileSystem.createFileExclusively(Native Method)
at java.io.File.createNewFile(File.java:1012)
at org.apache.kyuubi.engine.ProcBuilder.$anonfun$engineLog$6(ProcBuilder.scala:187)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.kyuubi.engine.ProcBuilder.engineLog(ProcBuilder.scala:184)
at org.apache.kyuubi.engine.ProcBuilder.engineLog$(ProcBuilder.scala:159)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.engineLog$lzycompute(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.engineLog(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.ProcBuilder.processBuilder(ProcBuilder.scala:141)
at org.apache.kyuubi.engine.ProcBuilder.processBuilder$(ProcBuilder.scala:135)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.processBuilder$lzycompute(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.processBuilder(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.ProcBuilder.start(ProcBuilder.scala:198)
at org.apache.kyuubi.engine.ProcBuilder.start$(ProcBuilder.scala:197)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.start(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.EngineRef.$anonfun$create$1(EngineRef.scala:194)
at org.apache.kyuubi.ha.client.zookeeper.ZookeeperDiscoveryClient.tryWithLock(ZookeeperDiscoveryClient.scala:174)
at org.apache.kyuubi.engine.EngineRef.tryWithLock(EngineRef.scala:160)
at org.apache.kyuubi.engine.EngineRef.create(EngineRef.scala:165)
at org.apache.kyuubi.engine.EngineRef.$anonfun$getOrCreate$1(EngineRef.scala:260)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.kyuubi.engine.EngineRef.getOrCreate(EngineRef.scala:260)
at org.apache.kyuubi.session.KyuubiSessionImpl.$anonfun$openEngineSession$1(KyuubiSessionImpl.scala:120)
at org.apache.kyuubi.session.KyuubiSessionImpl.$anonfun$openEngineSession$1$adapted(KyuubiSessionImpl.scala:113)
at org.apache.kyuubi.ha.client.DiscoveryClientProvider$.withDiscoveryClient(DiscoveryClientProvider.scala:36)
at org.apache.kyuubi.session.KyuubiSessionImpl.openEngineSession(KyuubiSessionImpl.scala:113)
at org.apache.kyuubi.operation.LaunchEngine.$anonfun$runInternal$2(LaunchEngine.scala:49)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
at org.apache.kyuubi.KyuubiSQLException$.apply(KyuubiSQLException.scala:69)
at org.apache.kyuubi.operation.KyuubiOperation$$anonfun$onError$1.applyOrElse(KyuubiOperation.scala:75)
at org.apache.kyuubi.operation.KyuubiOperation$$anonfun$onError$1.applyOrElse(KyuubiOperation.scala:56)
at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:38)
at org.apache.kyuubi.operation.LaunchEngine.$anonfun$runInternal$2(LaunchEngine.scala:51)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.IOException: 权限不够
at java.io.UnixFileSystem.createFileExclusively(Native Method)
at java.io.File.createNewFile(File.java:1012)
at org.apache.kyuubi.engine.ProcBuilder.$anonfun$engineLog$6(ProcBuilder.scala:187)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.kyuubi.engine.ProcBuilder.engineLog(ProcBuilder.scala:184)
at org.apache.kyuubi.engine.ProcBuilder.engineLog$(ProcBuilder.scala:159)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.engineLog$lzycompute(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.engineLog(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.ProcBuilder.processBuilder(ProcBuilder.scala:141)
at org.apache.kyuubi.engine.ProcBuilder.processBuilder$(ProcBuilder.scala:135)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.processBuilder$lzycompute(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.processBuilder(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.ProcBuilder.start(ProcBuilder.scala:198)
at org.apache.kyuubi.engine.ProcBuilder.start$(ProcBuilder.scala:197)
at org.apache.kyuubi.engine.spark.SparkProcessBuilder.start(SparkProcessBuilder.scala:36)
at org.apache.kyuubi.engine.EngineRef.$anonfun$create$1(EngineRef.scala:194)
at org.apache.kyuubi.ha.client.zookeeper.ZookeeperDiscoveryClient.tryWithLock(ZookeeperDiscoveryClient.scala:174)
at org.apache.kyuubi.engine.EngineRef.tryWithLock(EngineRef.scala:160)
at org.apache.kyuubi.engine.EngineRef.create(EngineRef.scala:165)
at org.apache.kyuubi.engine.EngineRef.$anonfun$getOrCreate$1(EngineRef.scala:260)
at scala.Option.getOrElse(Option.scala:189)
at org.apache.kyuubi.engine.EngineRef.getOrCreate(EngineRef.scala:260)
at org.apache.kyuubi.session.KyuubiSessionImpl.$anonfun$openEngineSession$1(KyuubiSessionImpl.scala:120)
at org.apache.kyuubi.session.KyuubiSessionImpl.$anonfun$openEngineSession$1$adapted(KyuubiSessionImpl.scala:113)
at org.apache.kyuubi.ha.client.DiscoveryClientProvider$.withDiscoveryClient(DiscoveryClientProvider.scala:36)
at org.apache.kyuubi.session.KyuubiSessionImpl.openEngineSession(KyuubiSessionImpl.scala:113)
at org.apache.kyuubi.operation.LaunchEngine.$anonfun$runInternal$2(LaunchEngine.scala:49)
... 5 more (state=,code=0)
```
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #4302 from pan3793/info.
Closes #4302
24c8ab39d [Cheng Pan] Change log level from debug to info for creating work dir
Authored-by: Cheng Pan <ch...@apache.org>
Signed-off-by: Cheng Pan <ch...@apache.org>
(cherry picked from commit 7cd206642c962b233a86edfe17f0bb0c99e34c70)
Signed-off-by: Cheng Pan <ch...@apache.org>
---
.../src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
index 65c457601..5c1d107e0 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
@@ -110,7 +110,7 @@ trait ProcBuilder {
env.get("KYUUBI_WORK_DIR_ROOT").map { root =>
val workingRoot = Paths.get(root).toAbsolutePath
if (!Files.exists(workingRoot)) {
- debug(s"Creating KYUUBI_WORK_DIR_ROOT at $workingRoot")
+ info(s"Creating KYUUBI_WORK_DIR_ROOT at $workingRoot")
Files.createDirectories(workingRoot)
}
if (Files.isDirectory(workingRoot)) {
@@ -119,7 +119,7 @@ trait ProcBuilder {
}.map { rootAbs =>
val working = Paths.get(rootAbs, proxyUser)
if (!Files.exists(working)) {
- debug(s"Creating $proxyUser's working directory at $working")
+ info(s"Creating $proxyUser's working directory at $working")
Files.createDirectories(working)
}
if (Files.isDirectory(working)) {