You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Jorge Solórzano (Jira)" <ji...@apache.org> on 2023/11/03 17:35:00 UTC

[jira] [Commented] (MCOMPILER-542) clean JDK patch version in module-info.class

    [ https://issues.apache.org/jira/browse/MCOMPILER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782681#comment-17782681 ] 

Jorge Solórzano commented on MCOMPILER-542:
-------------------------------------------

Hi [~hboutemy], I could start to make a workaround for this, but as I never touched ASM before the idea is to put this behind a parameter to enable the rewrite (disabled by default), and if it works as expected after one or two releases, drop the flag and make it enabled by default, I'm not sure if this is correct (remove the parameter) since there are a couple of parameters that are deprecated but are never removed, the other option is to have this always enabled.  WDYT?

> clean JDK patch version in module-info.class
> --------------------------------------------
>
>                 Key: MCOMPILER-542
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-542
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.11.0
>            Reporter: Herve Boutemy
>            Priority: Major
>
> as seen in MJAR-275, JDK patch version in module-info.class is not included only when building with a newer JDK release using "--release" flag, see https://github.com/jvm-repo-rebuild/module-info
> we need an issue in JDK to get a proper fix
> and waiting for. that, we need a workaround to drop the JDK patch version in other cases: we'll need to define were is the best place -- m-jar-p?m-compiler-p? other?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)