You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "joao-martins-tdx (via GitHub)" <gi...@apache.org> on 2023/09/23 18:46:39 UTC
[GitHub] [camel] joao-martins-tdx opened a new pull request, #11540: (chores) doc: add missing word in getting-started guide
joao-martins-tdx opened a new pull request, #11540:
URL: https://github.com/apache/camel/pull/11540
# Description
The part of the "Routes" section of the getting-started guide that reads "a predicate that tests if the body of the matches" seems to be missing the word "message" between "the body of the" and "matches". The purpose of this PR is to the add that word to that part of the guide in order to make it slightly clearer.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11540: (chores) doc: add missing word in getting-started guide
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11540:
URL: https://github.com/apache/camel/pull/11540#issuecomment-1732389160
Thanks for contributing :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11540: (chores) doc: add missing word in getting-started guide
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11540:
URL: https://github.com/apache/camel/pull/11540#issuecomment-1732388672
If you want to build, you should run the full build from the root folder of the project. Since it's doc, it's not required in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] joao-martins-tdx commented on pull request #11540: (chores) doc: add missing word in getting-started guide
Posted by "joao-martins-tdx (via GitHub)" <gi...@apache.org>.
joao-martins-tdx commented on PR #11540:
URL: https://github.com/apache/camel/pull/11540#issuecomment-1732387619
> I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
Is this part of the coding standards and style checklist required for this PR?
I've tried to run it but the build is failing with the following error:
```
Plugin org.apache.camel:camel-package-maven-plugin:4.1.0-SNAPSHOT or one of its dependencies could not
be resolved: Could not find artifact org.apache.camel:camel-package-maven-plugin:jar:4.1.0-SNAPSHOT
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] joao-martins-tdx commented on pull request #11540: (chores) doc: add missing word in getting-started guide
Posted by "joao-martins-tdx (via GitHub)" <gi...@apache.org>.
joao-martins-tdx commented on PR #11540:
URL: https://github.com/apache/camel/pull/11540#issuecomment-1732388930
> If you want to build, you should run the full build from the root folder of the project. Since it's doc, it's not required in this case
OK. Thanks for the clarification @oscerd!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #11540: (chores) doc: add missing word in getting-started guide
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #11540:
URL: https://github.com/apache/camel/pull/11540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org