You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/24 09:35:54 UTC

[GitHub] [spark] cxzl25 opened a new pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

cxzl25 opened a new pull request #30916:
URL: https://github.com/apache/spark/pull/30916


   ### What changes were proposed in this pull request?
   Shuffle Read Size / Records can also be displayed in remoteBytesRead>0 localBytesRead=0.
   
   ### Why are the changes needed?
   At present, the page only displays the data of Shuffle Read Size / Records when localBytesRead>0.
   When there is only remote reading, metrics cannot be seen on the stage page.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   manual test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750875546


   **[Test build #133352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133352/testReport)** for PR 30916 at commit [`1e776ad`](https://github.com/apache/spark/commit/1e776aded88b20ac22f4fb2e398e6aa464b9b522).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750842858


   **[Test build #133352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133352/testReport)** for PR 30916 at commit [`1e776ad`](https://github.com/apache/spark/commit/1e776aded88b20ac22f4fb2e398e6aa464b9b522).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cxzl25 commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750825033


   current:  
   ![image](https://user-images.githubusercontent.com/3898450/103079421-c4ca2280-460e-11eb-9e2f-49d35b5d324d.png)
   after:  
   ![image](https://user-images.githubusercontent.com/3898450/103079439-cc89c700-460e-11eb-9a41-6b2882980d11.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cxzl25 edited a comment on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
cxzl25 edited a comment on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750825033


   current:  
   ![image](https://user-images.githubusercontent.com/3898450/103079421-c4ca2280-460e-11eb-9e2f-49d35b5d324d.png)
   fix:  
   ![image](https://user-images.githubusercontent.com/3898450/103079439-cc89c700-460e-11eb-9a41-6b2882980d11.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750825576


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750917139


   Thanks @cxzl25 ! Merged to `master/branch-3.1/branch-3.0`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750876023


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133352/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750876023


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133352/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750854345


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37943/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750861136


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37943/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750888658


   @cxzl25 Nice catch. Could you copy the screen shots to the description ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] wangyum commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750837688


   ok to test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750825576


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750842858


   **[Test build #133352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133352/testReport)** for PR 30916 at commit [`1e776ad`](https://github.com/apache/spark/commit/1e776aded88b20ac22f4fb2e398e6aa464b9b522).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] asfgit closed pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #30916:
URL: https://github.com/apache/spark/pull/30916


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750861150


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37943/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #30916: [SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30916:
URL: https://github.com/apache/spark/pull/30916#issuecomment-750861150


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37943/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org