You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/01/17 22:05:40 UTC

[GitHub] brooklyn-server pull request #525: openstack-swift support

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/525

    openstack-swift support

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server openstack-swift-support

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #525
    
----
commit 68e90d1e5c7395f3ef649026743457abf3657fe9
Author: Aled Sage <al...@gmail.com>
Date:   2017-01-17T22:02:43Z

    Fix CloudExplorerLiveTest
    
    Use System.setOut() so it gets the real stdout/stderr.
    Had to make test more lenient, as this also gets log statements in 
    stdout.

commit 8d00784354d7be56f3f596f745bca9ce76c53d3b
Author: Aled Sage <al...@gmail.com>
Date:   2017-01-17T22:03:18Z

    ComputeServiceRegistry: don\u2019t log.warn on \u201cjclouds.*\u201d config

commit 63d1e6bf413af8e99b6cba9f6393965f6fcef9bb
Author: Aled Sage <al...@gmail.com>
Date:   2017-01-17T22:04:14Z

    BROOKLYN-359: support openstack-swift with jclouds2
    
    * Adds BlobStoreContextFactoryImpl (instead of using 
      JcloudsUtil.newBlobstoreContext, which is now deprecated).
    * Extracts \u201cjclouds.*\u201d from the location config, and passes it through
      to jclouds when creating the blobstore context.
    * Re-enables/fixes BlobStoreExpiryTest, to work with jclouds2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #525: openstack-swift support

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/525#discussion_r96591689
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/core/mgmt/persist/jclouds/JcloudsBlobStoreBasedObjectStore.java ---
    @@ -36,6 +36,7 @@
     import org.jclouds.blobstore.options.ListContainerOptions;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
    +import org.apache.brooklyn.location.jclouds.BlobStoreContextFactoryImpl;
    --- End diff --
    
    You have some unused imports in the class since you delete fews lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #525: openstack-swift support

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/525
  
    Thanks @tbouron - unused imports removed, rebased against master, and waiting for jenkins to re-run the tests. Then will merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #525: openstack-swift support

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/525


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #525: openstack-swift support

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-server/pull/525
  
    @aledsage Jenkins is happy now \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---