You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Emmanuel Lecharny <el...@gmail.com> on 2011/12/15 16:07:07 UTC
[MINA 3] filters chain modification
Hi,
I made some modification in the filter chain controller : we don't
anymore use some ThreadLocal variable to store the current filter
positions, we use plain int. The rationnal is that the controller is
associated with the session, not the service, ths there is no reason to
protect those variable against concurrent accesses.
Tests are passing ok.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA 3] filters chain modification
Posted by Julien Vermillard <jv...@gmail.com>.
On Sat, Dec 17, 2011 at 8:48 AM, Julien Vermillard
<jv...@gmail.com> wrote:
> On Thu, Dec 15, 2011 at 4:18 PM, Julien Vermillard
> <jv...@gmail.com> wrote:
>> On Thu, Dec 15, 2011 at 4:07 PM, Emmanuel Lecharny <el...@gmail.com> wrote:
>>> Hi,
>>>
>>> I made some modification in the filter chain controller : we don't anymore
>>> use some ThreadLocal variable to store the current filter positions, we use
>>> plain int. The rationnal is that the controller is associated with the
>>> session, not the service, ths there is no reason to protect those variable
>>> against concurrent accesses.
>>>
>>> Tests are passing ok.
>>>
>>
>> Great :)
> I'm going to change a bit the controller for not storing the chain but
> grabbing it from the session for being totally stateless.
> Julien
Even if it's xmas I killed the chain controller :)
http://svn.apache.org/viewvc?view=revision&revision=1222940
now the chain processing is done in AbstractIoSession.
Julien
Re: [MINA 3] filters chain modification
Posted by Julien Vermillard <jv...@gmail.com>.
On Thu, Dec 15, 2011 at 4:18 PM, Julien Vermillard
<jv...@gmail.com> wrote:
> On Thu, Dec 15, 2011 at 4:07 PM, Emmanuel Lecharny <el...@gmail.com> wrote:
>> Hi,
>>
>> I made some modification in the filter chain controller : we don't anymore
>> use some ThreadLocal variable to store the current filter positions, we use
>> plain int. The rationnal is that the controller is associated with the
>> session, not the service, ths there is no reason to protect those variable
>> against concurrent accesses.
>>
>> Tests are passing ok.
>>
>
> Great :)
I'm going to change a bit the controller for not storing the chain but
grabbing it from the session for being totally stateless.
Julien
Re: [MINA 3] filters chain modification
Posted by Julien Vermillard <jv...@gmail.com>.
On Thu, Dec 15, 2011 at 4:07 PM, Emmanuel Lecharny <el...@gmail.com> wrote:
> Hi,
>
> I made some modification in the filter chain controller : we don't anymore
> use some ThreadLocal variable to store the current filter positions, we use
> plain int. The rationnal is that the controller is associated with the
> session, not the service, ths there is no reason to protect those variable
> against concurrent accesses.
>
> Tests are passing ok.
>
Great :)