[jira] [Commented] (IMPALA-11669) Make Thrift max message size configuration

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627749#comment-17627749 ] 

ASF subversion and git services commented on IMPALA-11669:
----------------------------------------------------------

Commit a9786d34192552f2d725f2a107ccc19db3fb3e80 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a9786d341 ]

IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

This patch adds DefaultTConfiguration into TMemoryBuffer used within
DeserializeThriftMsg, ThriftSerializer, and TSaslTransport. This patch
also makes some adjustment, including:
- Refactor AssignDefaultTConfiguration to SetMaxMessageSize.
- Supply DefaultTConfiguration into the constructor of THttpTransport
  and TSaslTransport.
- Supply DefaultTConfiguration through the constructor of
  TBufferedTransport.

Testing:
- Add DCHECK_EQ in places where we expect that it should pick up
  DefaultTConfiguration.
- Add SerDeBuffer100MB test.
- Lower thrift_rpc_max_message_size to 128KB for all tests in
  thrift-server-test to avoid race condition.
- Pass core tests.
- Manually run and pass test scenario described in
  testdata/scale_test_metadata/ both in SSL and no SSL setup.

Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb
Reviewed-on: http://gerrit.cloudera.org:8080/19179
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Make Thrift max message size configuration
> ------------------------------------------
>
>                 Key: IMPALA-11669
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11669
>             Project: IMPALA
>          Issue Type: Task
>          Components: Backend
>    Affects Versions: Impala 4.2.0
>            Reporter: Joe McDonnell
>            Assignee: Riza Suminto
>            Priority: Critical
>             Fix For: Impala 4.2.0
>
>
> With the upgrade to Thrift 0.16, Thrift now has a protection against malicious message in the form of a maximum size for messages. This is currently set to 100MB by default. Impala should add the ability to override this default value. In particular, it seems like communication between coordinators and the catalogd may need a larger value.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org